Skip to content

Cplat capacity reservation feature #15523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 23, 2021
Merged

Cplat capacity reservation feature #15523

merged 11 commits into from
Jul 23, 2021

Conversation

grizzlytheodore
Copy link
Member

@grizzlytheodore grizzlytheodore commented Jul 22, 2021

Description

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/957
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/967

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@grizzlytheodore
Copy link
Member Author

waiting for #15511 to be merged first. which this branch is based onto.

@isra-fel
Copy link
Member

Now that 15511 was merged, please sync your branch and resolve the comflicts. Thanks

@isra-fel
Copy link
Member

I assume the design review for this PR is https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/967 correct?
Next time I suggest put that in PR description so we can easily find it. Thank you

@grizzlytheodore grizzlytheodore changed the title Cplat capacity reservation Cplat capacity reservation feature Jul 23, 2021
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@isra-fel isra-fel merged commit 0ac46a2 into main Jul 23, 2021
@isra-fel isra-fel deleted the cplat_capacityReservation branch July 23, 2021 09:03
@grizzlytheodore grizzlytheodore restored the cplat_capacityReservation branch July 23, 2021 16:46
@grizzlytheodore grizzlytheodore deleted the cplat_capacityReservation branch July 23, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants