Merge pull request #10233 from number213/nrp-team-alias

Use NrpTeamAlias in Network's tests to set ownership

Author: wyunchi-ms

src/Network/Network.Test/NrpTeamAlias.cs

@@ -49,5 +49,8 @@ class NrpTeamAlias
 
         //Azure NRP Firewall dev team
         public const string azurefirewall = "azurefirewall";
+
+        // Azure NRP bastion dev team
+        public const string bastion = "bastion";
     }
 }

src/Network/Network.Test/ScenarioTests/BastionTests.cs

@@ -28,31 +28,31 @@ public BastionTests(ITestOutputHelper output)
 
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
-        [Trait(Category.Owner, Category.bastion)]
+        [Trait(Category.Owner, NrpTeamAlias.bastion)]
         public void TestBastionCRUD()
         {
             TestRunner.RunTestScript("Test-BastionCRUD");
         }
 
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
-        [Trait(Category.Owner, Category.bastion)]
+        [Trait(Category.Owner, NrpTeamAlias.bastion)]
         public void TestBastionVnetsIpObjectsParams()
         {
             TestRunner.RunTestScript("Test-BastionVnetsIpObjectsParams");
         }
 
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
-        [Trait(Category.Owner, Category.bastion)]
+        [Trait(Category.Owner, NrpTeamAlias.bastion)]
         public void TestBastionVnetObjectParam()
         {
             TestRunner.RunTestScript("Test-BastionVnetObjectParam");
         }
 
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
-        [Trait(Category.Owner, Category.bastion)]
+        [Trait(Category.Owner, NrpTeamAlias.bastion)]
         public void TestBastionIpObjectParam()
         {
             TestRunner.RunTestScript("Test-BastionIpObjectParam");

src/Network/Network.Test/ScenarioTests/CortexTests.cs

@@ -29,23 +29,23 @@ public CortexTests(ITestOutputHelper output)
 
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
-        [Trait(Category.Owner, Category.brooklynft)]
+        [Trait(Category.Owner, NrpTeamAlias.brooklynft)]
         public void TestCortexCRUD()
         {
             TestRunner.RunTestScript("Test-CortexCRUD");
         }
 
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
-        [Trait(Category.Owner, Category.pgtm)]
+        [Trait(Category.Owner, NrpTeamAlias.pgtm)]
         public void TestCortexExpressRouteCRUD()
         {
             TestRunner.RunTestScript("Test-CortexExpressRouteCRUD");
         }
 
         [Fact]
         [Trait(Category.RunType, Category.LiveOnly)]
-        [Trait(Category.Owner, Category.brooklynft)]
+        [Trait(Category.Owner, NrpTeamAlias.brooklynft)]
         public void TestCortexDownloadConfig()
         {
             TestRunner.RunTestScript("Test-CortexDownloadConfig");

src/Network/Network.Test/ScenarioTests/ExpressRoutePortTests.cs

@@ -27,7 +27,7 @@ public ExpressRoutePortTests(Xunit.Abstractions.ITestOutputHelper output)
 
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
-        [Trait(Category.Owner, Category.pgtm)]
+        [Trait(Category.Owner, NrpTeamAlias.pgtm)]
         public void TestExpressRoutePortCRUDMinimalParameters()
         {
             TestRunner.RunTestScript(string.Format("Test-ExpressRoutePortCRUD"));

src/Network/Network.Test/ScenarioTests/ExpressRoutePortsLocationTests.cs

@@ -27,7 +27,7 @@ public ExpressRoutePortsLocationTests(Xunit.Abstractions.ITestOutputHelper outpu
 
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
-        [Trait(Category.Owner, Category.pgtm)]
+        [Trait(Category.Owner, NrpTeamAlias.pgtm)]
         public void TestExpressRoutePortsLocationRead()
         {
             TestRunner.RunTestScript(string.Format("Test-ExpressRoutePortsLocationRead"));

src/Network/Network.Test/ScenarioTests/NetworkWatcherAPITests.cs

@@ -75,7 +75,7 @@ public void TestTroubleshoot()
 
         [Fact]
         [Trait(Category.RunType, Category.LiveOnly)]
-        [Trait(Category.Owner, Category.netanalyticsdev)]
+        [Trait(Category.Owner, NrpTeamAlias.netanalyticsdev)]
         public void TestFlowLog()
         {
             TestRunner.RunTestScript("Test-FlowLog");

tools/ScenarioTest.ResourceManager/Constants.cs

@@ -59,35 +59,6 @@ public class Category
 
         public const string OneSDK = "OneSDK";
 
-        // Below is the list of aliases to contact on test behavior
-
-        // Virtual Appliance dev team
-        public const string nvadev = "nvadev";
-
-        // SDN NRP Dev Team
-        public const string sdnnrp = "sdnnrp";
-
-        // Pankaj's Team
-        public const string pgtm = "pgtm";
-
-        // Windows Azure SLB Dev Team
-        public const string slbdev = "slbdev";
-
-        // Brooklyn FTEs
-        public const string brooklynft = "brooklynft";
-
-        // Azure Network Analytics Dev Team
-        public const string netanalyticsdev = "netanalyticsdev";
-
-        // Windows Azure NRP dev team
-        public const string wanrpdev = "wanrpdev";
-
-        //Azure NRP Firewall dev team
-        public const string azurefirewall = "azurefirewall";
-
-        //Azure NRP bastion dev team
-        public const string bastion = "bastion";
-
         // Acceptance type
         public const string AcceptanceType = "AcceptanceType";