Use NrpTeamAlias in Network's tests to set ownership #10233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyunchi-ms
reviewed
Oct 10, 2019
Comment on lines
+52
to
+54
|
|
||
| // Azure NRP bastion dev team | ||
| public const string bastion = "bastion"; |
There was a problem hiding this comment.
Looks like bastion team is reorged to NRP dev team. Should it remove from Category?
There was a problem hiding this comment.
I think we can remove all NRP aliases from Category since they are duplicates (if you're okay with that)
There was a problem hiding this comment.
Sure~I think you can remove them if there is not any reference any more.
wyunchi-ms
reviewed
Oct 12, 2019
|
Done, @wyunchi-ms, please take a look |
wyunchi-ms
reviewed
Oct 15, 2019
Comment on lines
-62
to
-86
| // Below is the list of aliases to contact on test behavior | ||
|
|
||
| // Virtual Appliance dev team | ||
| public const string nvadev = "nvadev"; | ||
|
|
||
| // SDN NRP Dev Team | ||
| public const string sdnnrp = "sdnnrp"; | ||
|
|
||
| // Pankaj's Team | ||
| public const string pgtm = "pgtm"; | ||
|
|
||
| // Windows Azure SLB Dev Team | ||
| public const string slbdev = "slbdev"; | ||
|
|
||
| // Brooklyn FTEs | ||
| public const string brooklynft = "brooklynft"; | ||
|
|
||
| // Azure Network Analytics Dev Team | ||
| public const string netanalyticsdev = "netanalyticsdev"; | ||
|
|
||
| // Windows Azure NRP dev team | ||
| public const string wanrpdev = "wanrpdev"; | ||
|
|
||
| //Azure NRP Firewall dev team | ||
| public const string azurefirewall = "azurefirewall"; |
There was a problem hiding this comment.
Hi @number213 are these variables also duplicated?
There was a problem hiding this comment.
OK, there is not any reference of these variables in the code. They can be remove safely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures that all Network tests use the same class to set test ownership
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added