Skip to content

Modify Remove-AzSqlDatabaseAudit and Remove-AzSqlServerAudit #10000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 11, 2019
Merged

Modify Remove-AzSqlDatabaseAudit and Remove-AzSqlServerAudit #10000

merged 4 commits into from
Sep 11, 2019

Conversation

bashahee
Copy link
Contributor

@bashahee bashahee commented Sep 10, 2019

Description

This PR enables removing auditing settings of a server or a database when there are multiple diagnostic settings that enable the audit category.
Moreover, scenario tests were added to verify this change.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@bashahee bashahee changed the title Modify logic of Remove-AzSqlDatabaseAudit and Remove-AzSqlServerAudit Modify Remove-AzSqlDatabaseAudit and Remove-AzSqlServerAudit Sep 11, 2019
@erich-wang erich-wang merged commit b6dab3b into Azure:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants