Skip to content

Bug fix in New direct peering connection #10010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 13, 2019
Merged

Conversation

rileymckenna
Copy link
Contributor

@rileymckenna rileymckenna commented Sep 11, 2019

Description

Had to make a small change to direct peering connection. we added the concept of use for peering service at the connection

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@cormacpayne
Copy link
Member

@rileymckenna please make sure to update your module's ChangeLog.md file as well

Updated Changelog.md
@markcowl markcowl assigned rileymckenna and unassigned cormacpayne Sep 12, 2019
Copy link
Contributor Author

@rileymckenna rileymckenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready for merge

@markcowl markcowl dismissed cormacpayne’s stale review September 13, 2019 04:32

All comments addressed

@markcowl markcowl merged commit fcf9360 into Azure:master Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants