Skip to content

Fix Email validation util. Would currently flag mail addresses that s… #10019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 16, 2019
Merged

Fix Email validation util. Would currently flag mail addresses that s… #10019

merged 6 commits into from
Sep 16, 2019

Conversation

yoavfr
Copy link
Contributor

@yoavfr yoavfr commented Sep 12, 2019 •
edited
Loading

Description

Fix Email validation in Util.cs. Would currently flag mail addresses that start with capital letter as invalid.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@yoavfr yoavfr requested review from talhers and shblum September 12, 2019 11:38
shblum
shblum reviewed Sep 12, 2019
View reviewed changes
markcowl
markcowl requested changes Sep 13, 2019
View reviewed changes
Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entry? Tests?

@yoavfr yoavfr requested a review from markcowl September 14, 2019 11:24
shblum
shblum previously approved these changes Sep 15, 2019
View reviewed changes
@markcowl
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@markcowl
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@markcowl markcowl merged commit b625f3d into master Sep 16, 2019
@cormacpayne cormacpayne deleted the fixEmailValidation branch September 18, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markcowl markcowl markcowl approved these changes

@talhers talhers talhers approved these changes

@shblum shblum shblum left review comments

Assignees

@yoavfr yoavfr

Labels
Sprint Candidate Waiting for CI :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yoavfr @adxsdkps @markcowl @talhers @shblum @azuresdkci