Skip to content

Add deprecation notice on Batch cmdlet #10079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

matthchr
Copy link
Member

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

The upcoming breaking change has already been signed off and merged in #10001

@erich-wang erich-wang self-assigned this Sep 23, 2019
Copy link
Member

@erich-wang erich-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthchr , please update ChangeLog.md for your service,
src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md

@markcowl
Copy link
Member

@matthchr this will be ready to merge once you add a changelog update

@matthchr matthchr force-pushed the feature/deprecate-cmdlet branch from 84c9317 to 5e45c3d Compare September 26, 2019 15:55
@matthchr
Copy link
Member Author

Updated Changelog

@markcowl markcowl dismissed erich-wang’s stale review September 27, 2019 02:56

All review comments addressed

@markcowl markcowl merged commit c502819 into Azure:master Sep 27, 2019
@matthchr matthchr deleted the feature/deprecate-cmdlet branch September 27, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants