Skip to content

Added commands for working with Access Restrictions #10085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 8, 2019
Merged

Added commands for working with Access Restrictions #10085

merged 6 commits into from
Oct 8, 2019

Conversation

madsd
Copy link
Contributor

@madsd madsd commented Sep 23, 2019

Description

Fixes: #8459 : webapp: add support to add IPRestrictions rules

Checklist

  • [ x] I have read the Submitting Changes section of CONTRIBUTING.md
  • [x ] The title of the PR is clear and informative
  • [x ] The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • [x ] The PR does not introduce breaking changes
  • [ x] If applicable, the changes made in the PR have proper test coverage
  • [ x] For public API changes to cmdlets:

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@madsd madsd added the Web Apps label Sep 23, 2019
@msJinLei msJinLei self-assigned this Sep 24, 2019
@markcowl markcowl assigned wyunchi-ms and unassigned msJinLei Sep 26, 2019
markcowl
markcowl requested changes Oct 1, 2019
View reviewed changes
Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cmdlets in this PR do not match the cmdlets in the cmdlet review. You will need to complete the cmdlet review before this PR can be merged.

src/Websites/Websites/Cmdlets/AccessRestriction/UpdateAzureWebAppAccessRestrictionConfig.cs Outdated
/// <summary>
/// this commandlet will let you update the access restriction settings of an Azure Website
/// </summary>
[Cmdlet("Update", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "WebAppAccessRestrictionConfig", SupportsShouldProcess = true)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cmdlet is causing your analysis failure, you need to have a DefaultParameyterSetName if there is mroe than one parameter set

markcowl
markcowl requested changes Oct 4, 2019
View reviewed changes
Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On eminor change to changelog, otherwise LGTM

@markcowl markcowl assigned madsd and unassigned wyunchi-ms Oct 4, 2019
@markcowl markcowl merged commit e8e41b5 into Azure:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markcowl markcowl markcowl approved these changes

Assignees

@madsd madsd

Labels
Cmdlet Review Complete Sprint Candidate Waiting for CI :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

webapp: add support to add IPRestrictions rules
7 participants
@madsd @adxsdkps @markcowl @azuresdkci @erich-wang @msJinLei @wyunchi-ms