Adding new dsc extension status cmdlet #102
Conversation
… it more readable
…one. This was done to maintain consistency across all other cmdlets
|
Hi @vors, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
| GetDeploymentOperationNewSM = GetOperationNewSM(CurrentDeploymentNewSM.RequestId); | ||
| WriteVerboseWithTimestamp(Resources.GetDeploymentCompletedOperation); | ||
| } | ||
| catch (CloudException ex) |
|
@vors Need to update the new cmdlet for the changes in the latest common library (for example CloudException -> HttpOperationException) |
Conflicts: src/ServiceManagement/Compute/Commands.ServiceManagement.Extensions.Test/Commands.ServiceManagement.Extensions.Test.csproj
|
@vors, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
Conflicts: src/ServiceManagement/Compute/Commands.ServiceManagement/IaaS/Extensions/DSC/GetAzureVMDscExtensionStatus.cs
|
@vors - we are planning to discontinue mstest runner in the near future. Please update your tests to use XUnit |
| /// Get-AzureVMDscExtensionStatus -ServiceName service -Name VM-name | ||
| /// Get-AzureVMDscExtensionStatus -VM vm | ||
| /// </summary> | ||
| [Cmdlet(VerbsCommon.Get, VirtualMachineDscStatusCmdletNoun, DefaultParameterSetName = GetStatusByServiceAndVmNameParamSet), OutputType(typeof(VirtualMachineDscExtensionStatusContext))] |
There was a problem hiding this comment.
Wrap long lines for readability
|
|
||
| if (roleInstance != null && roleInstance.ResourceExtensionStatusList != null) | ||
| { | ||
| foreach (var resourceExtensionStatus in roleInstance.ResourceExtensionStatusList.Where(resourceExtensionStatus => resourceExtensionStatus.HandlerName.Equals(VirtualMachineDscExtensionCmdletBase.ExtensionPublishedNamespace + "." + VirtualMachineDscExtensionCmdletBase.ExtensionPublishedName, StringComparison.InvariantCultureIgnoreCase)).Where(resourceExtensionStatus => resourceExtensionStatus.ExtensionSettingStatus != null)) |
There was a problem hiding this comment.
440+ characters on a line is excessive. Split appropriately.
Adding new dsc extension status cmdlet
TrafficManager2 cmdlets for build
Fix AzureRT test settings
Changes for the new cmdlet - Get-AzureVMDSCExtensionStatus that gets the DSC Extension status for all the vm's deployed in a cloud service or for a particular vm in the service.