Azure Firewall Policy Commandlets

[saisujithreddym]

Description

The changes include adding new commandlets to support azure firewall policy operation.
Design review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/389

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate ChangeLog.md file(s) has been updated:
  • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
  • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  • the markdown help files have been regenerated using the commands listed here

Note

There were some changes regarding the commandlet names after the design review:

• RuleCondition is renamed to Rule
• Rule is renamed to RuleCollection
• RuleGroup is renamed to RuleCollectionGroup

[saisujithreddym]

All the comments are resolved and all the checks are passing. Please let me know if there are any more comments :)

[anton-evseev]

LGTM but is there a reason why most of new models' properties are names in camelCase? C#'s conventions are to name them in PascalCase. It won't be a problem for AutoMapper

[saisujithreddym]

This was a one off thing where we had to use a polymorphic JSON converter to convert from the PS object to the sdk object and it was just accepting the camel case.

[isra-fel]

LGTM but is there a reason why most of new models' properties are names in camelCase? C#'s conventions are to name them in PascalCase. It won't be a problem for AutoMapper

Thanks for pointing that out!

This was a one off thing where we had to use a polymorphic JSON converter to convert from the PS object to the sdk object and it was just accepting the camel case.

@saisujithreddym , please use the following syntax to specify the property name in JSON:

[JsonProperty(PropertyName="key", Order=3)]
string Key { get; set; }

Thanks

[saisujithreddym]

@isra-fel I was thinking about the same solution lately and was working on it on the sidelines. I have pushed the changes. Please let me know if you have any more comments.