-
Notifications
You must be signed in to change notification settings - Fork 4k
Adding support for restore of deleted managed databases. #10241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can one of the admins verify this patch? |
Not sure if cmdlet review is necessary, but I created an issue regardless. Link: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/399 |
@djnisic a reminder, please update the breaking change suppression file after confirming with us -- we wouldn't want real breaking change to be in the official release. BTW, I'll look at the PR later. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @djnisic , sorry for late response.
I was thinking giving an example in readme would be better 🤔
And please see my inline comments. Thanks
Can you expand a bit more on example in readme? I am not sure what exactly do you mean? |
What I meant to say was the "Example" section in "Restore-AzSqlInstanceDatabase.md". |
Added 2 examples for deleted databases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Description
Adding support for restore of deleted databases on Managed Instance. This includes adding new parameter set options and tests.
Did minor refactoring of already existing code.
Design review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/399
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added