Skip to content

Adding support for restore of deleted managed databases. #10241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2019

Conversation

djnisic
Copy link
Contributor

@djnisic djnisic commented Oct 10, 2019

Description

Adding support for restore of deleted databases on Managed Instance. This includes adding new parameter set options and tests.

Did minor refactoring of already existing code.

Design review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/399

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@djnisic
Copy link
Contributor Author

djnisic commented Oct 10, 2019

Not sure if cmdlet review is necessary, but I created an issue regardless. Link: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/399

@msJinLei msJinLei self-assigned this Oct 11, 2019
@isra-fel
Copy link
Member

@djnisic a reminder, please update the breaking change suppression file after confirming with us -- we wouldn't want real breaking change to be in the official release.

BTW, I'll look at the PR later. Thanks

@djnisic
Copy link
Contributor Author

djnisic commented Oct 15, 2019

@djnisic a reminder, please update the breaking change suppression file after confirming with us -- we wouldn't want real breaking change to be in the official release.

BTW, I'll look at the PR later. Thanks

@isra-fel Friendly ping!

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @djnisic , sorry for late response.
I was thinking giving an example in readme would be better 🤔
And please see my inline comments. Thanks

@djnisic
Copy link
Contributor Author

djnisic commented Oct 16, 2019

Hi @djnisic , sorry for late response.
I was thinking giving an example in readme would be better 🤔
And please see my inline comments. Thanks

Can you expand a bit more on example in readme? I am not sure what exactly do you mean?

@isra-fel
Copy link
Member

isra-fel commented Oct 16, 2019

Can you expand a bit more on example in readme? I am not sure what exactly do you mean?

What I meant to say was the "Example" section in "Restore-AzSqlInstanceDatabase.md".

@djnisic
Copy link
Contributor Author

djnisic commented Oct 16, 2019

Can you expand a bit more on example in readme? I am not sure what exactly do you mean?

What I meant to say was the "Example" section in "Restore-AzSqlInstanceDatabase.md".

Added 2 examples for deleted databases.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@isra-fel isra-fel merged commit a833c07 into Azure:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants