Fixed bug and added more tests

[rileymckenna]

Description

Fixed bug in get Peering location
Added more tests that would have caught this bug
Added more tests to direct connection

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate ChangeLog.md file(s) has been updated:
  • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
  • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  • the markdown help files have been regenerated using the commands listed here

[msJinLei]

@rileymckenna could you provide the issue reference of the fix & please fix the test error.

[rileymckenna]

#10297

[rileymckenna]

@msJinLei what needs to be revised?

[msJinLei]

@msJinLei what needs to be revised?

Add breaking change notification above the parameter you make the change with. You can find the sample code in the url I list.

[rileymckenna]

According to the documentation, this is not a case where i have to add a breaking change. The mandatory field is supposed to be false. @msJinLei

[msJinLei]

According to the documentation, this is not a case where i have to add a breaking change. The mandatory field is supposed to be false. @msJinLei

You remove positioning attribute of a parameter.

[wyunchi-ms]

Hi @rileymckenna , this pr last for a long time. Do you still need this pr? If yes, could you please take a look at this issue? We may close this issue in a few days, if it's no longger needed.

[msJinLei]

According to the documentation, this is not a case where i have to add a breaking change. The mandatory field is supposed to be false. @msJinLei

You remove positioning attribute of a parameter.

@wyunchi-ms I don't notice that this is a preview release.
@rileymckenna Please change the changelog.md and then we can merge the PR.

[msJinLei]

change the changelog.md

[rileymckenna]

@msJinLei i apologize i was out of the office for the beginning of the week.