[storage] Support enable large file shares #10276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msJinLei
assigned
isra-fel,
msJinLei and
wyunchi-ms and unassigned
msJinLei and
isra-fel
wyunchi-ms
reviewed
Oct 15, 2019
Comment on lines
+161
to
+163
| public void TestNewSetAzureStorageAccount_LargeFileShare() | ||
| { | ||
| TestRunner.RunTestScript("Test-NewSetAzureStorageAccount_LargeFileShare"); |
There was a problem hiding this comment.
Why using _ here instead of using CamelCase？
There was a problem hiding this comment.
@wyunchi-ms
Does it break any rule?
I use _ since the NewSetStorageAccount is long and want to show what's the case really test more obviously
I don't prefer to change it, since it will take difficulty to merge changes back to storage branch.
Anyway, if it do break some name rules, I can change it.
| .DESCRIPTION | ||
| SmokeTest | ||
| #> | ||
| function Test-NewSetAzureStorageAccount_LargeFileShare |
There was a problem hiding this comment.
Why using _ here instead of using CamelCase？
wyunchi-ms
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The design pass review in: Azure/azure-powershell-cmdlet-review-pr#386
The PR has already been merged to storage preview branch before : #10234
This workitem is tracking it.: #10263
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added