Update to R5 RP 2019-07-01 API (#27)

[leonardbf]

• new .net SDK version
• nfsv4 renamed to nfsv4.1
• snapshot creation date renamed to created
• internal ticket ANF-243

Description

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate ChangeLog.md file(s) has been updated:
  • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
  • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  • the markdown help files have been regenerated using the commands listed here

[leonardbf]

Could do with some info on the failure https://dev.azure.com/azure-sdk/public/_build/results?buildId=144087&view=logs&jobId=e1b7b984-9f58-529f-7c5a-f15f8e35cfa6 please.
Where can I see the output from the pipeline? I've ran msbuild locally according to the linked page but do not see issues there.

[wyunchi-ms]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[VeryEarly]

properties "Nfsv4" and "CreationData" were renamed and were treated as breaking changes by system, suppress following error messages

https://dev.azure.com/azure-sdk/public/_build/results?buildId=161091&view=artifacts
in this page go to analyze-windows/StaticAnalysisResults/BreakingChangeIssues.csv, copy errors into
"./tools/StaticAnalysis/Exceptions/Az.NetAppFiles/BreakingChangeIssues.csv"

Also you can check https://github.com/Azure/azure-powershell/blob/master/documentation/Debugging-StaticAnalysis-Errors.md for detail.

[leonardbf]

properties "Nfsv4" and "CreationData" were renamed and were treated as breaking changes by system, suppress following error messages

https://dev.azure.com/azure-sdk/public/_build/results?buildId=161091&view=artifacts
in this page go to analyze-windows/StaticAnalysisResults/BreakingChangeIssues.csv, copy errors into
"./tools/StaticAnalysis/Exceptions/Az.NetAppFiles/BreakingChangeIssues.csv"

Also you can check https://github.com/Azure/azure-powershell/blob/master/documentation/Debugging-StaticAnalysis-Errors.md for detail.

ok, I have updated that file and the pipeline now passes.

[VeryEarly]

how is this line different?

[leonardbf]

Hmmm, really can't say. I don't see any difference and have not made any change to it.

[VeryEarly]

Check if there are any white spaces, could be caused by your text editor.
Also simply fix the merge conflict, let me know if you have any update.
I'll try to merge it for you as soon as I can.

[leonardbf]

I suspect it was caused by the editor but there is no whitespace difference.

Concerning the merge conflicts, because this is test record files and there are too many diffs to fix in github, I know of no other way than cloning from azure, force pushing to my fork, reapplying all the changes and then rerunning all the tests. It also means the PR is closed and a new one must be opened. This is time consuming and happens a lot while things are in review. Is there a shorter way? Thanks.

[isra-fel]

Try rebasing: https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md#rebasing

No need to close this or create a new PR, and no need to run all the tests by the way -- only the four tests that have conflicts need to be re-ran.

[leonardbf]

I didn't have luck with rebasing but anyway the closure of the PR is not something I manually do but seems to occur with the force push. I will try again next time but for now this PR has closed and I will link another shortly.
Regarding the diff mentioned above, I've now seen that this is because the original file contains '<EF><BB><BF>' which was stripped out.

[leonardbf]

PR replaced by #10445