-
Notifications
You must be signed in to change notification settings - Fork 4k
Add UrlRewriteAction and CacheKeyQueryStringAction to CDN rulesEngine #10324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Should also add the changelist to changelog.md
- add test for the bug fix & the new parameter sets
I have added a unittest to cover the bug fix and new actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix test failure
I have updated change log. The unittest is working locally but I don't know why it is failing on cloud. @msJinLei can you help me fix the tests? |
/azp run powershell-core |
Azure Pipelines successfully started running 1 pipeline(s). |
No pipelines are associated with this pull request. |
/azp run windows-powershell |
No pipelines are associated with this pull request. |
Hi @msJinLei , cloud tests are still failing for some unknown reason. Can you help me fix them? We need this change to be shipped by Ignite. |
The test cases fail in Test-EndpointCreateWithRulesEngine(line:115). Please take a look at that case. https://dev.azure.com/azure-sdk/public/_build/results?buildId=163083&view=results |
/azp run azure-powershell - powershell-core |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @msJinLei , you are looking at errors in an old build which should have been fixed now. In the latest build https://github.com/Azure/azure-powershell/pull/10324/checks?check_run_id=272112276 the test are failing beacuse of some CI issue. |
Description
Add UrlRewriteAction and CacheKeyQueryStringAction to CDN rulesEngine.
Fixed some old bugs like missing "selector" input in New-AzCdnDeliveryRuleCondition
DesignReview https://github.com/issues?q=is%3Aissue+author%3Ahytao+archived%3Afalse+is%3Aclosed
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added