Skip to content

Add UrlRewriteAction and CacheKeyQueryStringAction to CDN rulesEngine #10324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 24, 2019

Conversation

hytao
Copy link

@hytao hytao commented Oct 17, 2019

Description

Add UrlRewriteAction and CacheKeyQueryStringAction to CDN rulesEngine.
Fixed some old bugs like missing "selector" input in New-AzCdnDeliveryRuleCondition

DesignReview https://github.com/issues?q=is%3Aissue+author%3Ahytao+archived%3Afalse+is%3Aclosed

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@hytao hytao requested a review from markcowl October 17, 2019 21:24
@wyunchi-ms wyunchi-ms assigned isra-fel and msJinLei and unassigned isra-fel Oct 17, 2019
Copy link
Contributor

@msJinLei msJinLei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Should also add the changelist to changelog.md
  • add test for the bug fix & the new parameter sets

@hytao
Copy link
Author

hytao commented Oct 21, 2019

I have added a unittest to cover the bug fix and new actions.
Changelog has been updated as well

Copy link
Contributor

@msJinLei msJinLei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix test failure

@hytao
Copy link
Author

hytao commented Oct 22, 2019

I have updated change log.

The unittest is working locally but I don't know why it is failing on cloud. @msJinLei can you help me fix the tests?

@msJinLei
Copy link
Contributor

msJinLei commented Oct 23, 2019

/azp run powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link
Contributor

No pipelines are associated with this pull request.

@msJinLei
Copy link
Contributor

/azp run windows-powershell

@azure-pipelines
Copy link
Contributor

No pipelines are associated with this pull request.

@hytao
Copy link
Author

hytao commented Oct 23, 2019

Hi @msJinLei , cloud tests are still failing for some unknown reason. Can you help me fix them? We need this change to be shipped by Ignite.

@msJinLei
Copy link
Contributor

msJinLei commented Oct 24, 2019

Hi @msJinLei , cloud tests are still failing for some unknown reason. Can you help me fix them? We need this change to be shipped by Ignite.

The test cases fail in Test-EndpointCreateWithRulesEngine(line:115). Please take a look at that case.

https://dev.azure.com/azure-sdk/public/_build/results?buildId=163083&view=results

@markcowl
Copy link
Member

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@hytao
Copy link
Author

hytao commented Oct 24, 2019

Hi @msJinLei , you are looking at errors in an old build which should have been fixed now. In the latest build https://github.com/Azure/azure-powershell/pull/10324/checks?check_run_id=272112276 the test are failing beacuse of some CI issue.

@msJinLei msJinLei merged commit 8440e75 into Azure:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants