-
Notifications
You must be signed in to change notification settings - Fork 4k
Update Network SDK to use API version 2019-09-01 #10332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
anton-evseev
merged 10 commits into
Azure:network-october
from
anton-evseev:network-2019-09-01
Oct 21, 2019
Merged
Update Network SDK to use API version 2019-09-01 #10332
anton-evseev
merged 10 commits into
Azure:network-october
from
anton-evseev:network-2019-09-01
Oct 21, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isra-fel
approved these changes
Oct 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me
Fix CI error please @number213
|
Given @isra-fel's approval, "waiting for CI" label and the need to unblock other PRs, I'll go ahead and merge this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ExpressRouteCircuitTests.TestExpressRouteLocalCircuit
as server's behavior was changed, it no longer should throw an errorNetworkWatcherAPITests.TestProvidersList
as skipped as this API isn't available to customersUsageTestsGenerated
as it's basically a duplciate ofUsageTests
TestPublicIpAddressCRUD.json
from the root ofNetwork.Test
. This was old recording that somehow ended up in wrong folder.Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added