Skip to content

Update Network SDK to use API version 2019-09-01 #10332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 21, 2019

Conversation

anton-evseev
Copy link
Contributor

@anton-evseev anton-evseev commented Oct 18, 2019

Description

  • Added signed Network SDK package. We will replace it will SDK from NuGet once it's released (ETA: 10/23, before we merge our release branch into master)
  • Updated test recordings (with some test modifications)
  • Removed parts of ExpressRoute tests with "AzurePublicPeering" as this feature was deprecated
  • Removed test ExpressRouteCircuitTests.TestExpressRouteLocalCircuit as server's behavior was changed, it no longer should throw an error
  • Marked NetworkWatcherAPITests.TestProvidersList as skipped as this API isn't available to customers
  • Removed UsageTestsGenerated as it's basically a duplciate of UsageTests
  • Removed TestPublicIpAddressCRUD.json from the root of Network.Test. This was old recording that somehow ended up in wrong folder.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@anton-evseev
Copy link
Contributor Author

@isra-fel please take a look. This PR is the base for #10323 and #10317 as they required API version 2019-09-01

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me

@isra-fel
Copy link
Member

Fix CI error please @number213

Commands.Network.Test.ScenarioTests.AzureFirewallTests.TestAzureFirewallVirtualHubCRUD [FAIL]

@anton-evseev
Copy link
Contributor Author

Given @isra-fel's approval, "waiting for CI" label and the need to unblock other PRs, I'll go ahead and merge this PR

@anton-evseev anton-evseev merged commit b1506d7 into Azure:network-october Oct 21, 2019
@anton-evseev anton-evseev deleted the network-2019-09-01 branch October 21, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants