Skip to content

Fix enabling CDN custom domain HTTPS for Microsoft, Akamai CDN #10366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

fore5fire
Copy link
Contributor

@fore5fire fore5fire commented Oct 23, 2019

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@wyunchi-ms
Copy link
Contributor

Hi @lsmith130.

  1. Is there any issue reference to this pr?
  2. Could you please add test case for this fix?

Thanks!

@isra-fel
Copy link
Member

Kindly ping @lsmith130

@fore5fire fore5fire force-pushed the bug/cdn/custom-domain-https branch from e6eec14 to f425026 Compare November 15, 2019 23:57
@fore5fire
Copy link
Contributor Author

Fixes #9957

@wyunchi-ms wyunchi-ms merged commit edbef15 into Azure:master Nov 18, 2019
@fore5fire fore5fire deleted the bug/cdn/custom-domain-https branch November 18, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants