Skip to content

Remove cmdlet Add-AzServiceFabricApplicationCertificate #10367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2019
Merged

Remove cmdlet Add-AzServiceFabricApplicationCertificate #10367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abbe57c
remove cmdlet Add-AzServiceFabricApplicationCertificate
Oct 23, 2019
06ad3bb
add remove cmdlet to breakingchanges exceptions
Oct 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions src/ServiceFabric/ServiceFabric.Test/ScenarioTests/TestServiceFabric.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,22 +167,6 @@ public void TestRemoveAzureRmServiceFabricNodeType()
TestController.NewInstance.RunPsTest(_logger, "Test-RemoveAzureRmServiceFabricNodeType");
}

[Fact, TestPriority(0)]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TestAddAzureRmServiceFabricApplicationCertificate()
{
ServiceFabricCmdletBase.TestAppCert = true;
TestController.NewInstance.RunPsTest(_logger, "Test-AddAzureRmServiceFabricApplicationCertificate");
}

[Fact, TestPriority(0)]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TestAddAzureRmServiceFabricApplicationCertificateRollback()
{
ServiceFabricCmdletBase.TestAppCert = true;
TestController.NewInstance.RunPsTest(_logger, "Test-AddAzureRmServiceFabricApplicationCertificateRollback");
}

[Fact, TestPriority(0)]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void DefaultTemplateFilesAvailable()
Expand Down
35 changes: 0 additions & 35 deletions src/ServiceFabric/ServiceFabric.Test/ScenarioTests/TestServiceFabric.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,39 +293,4 @@ function Test-SetAzureRmServiceFabricUpgradeType
$cluster = Set-AzServiceFabricUpgradeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -UpgradeMode Manual -Verbose
$clusters = Get-AzServiceFabricCluster -ClusterName $clusterName -ResourceGroupName $resourceGroupName
Assert-AreEqual $clusters[0].UpgradeMode 'Manual'
}

function Test-AddAzureRmServiceFabricApplicationCertificate
{
$clusterName = Get-ClusterName
$resourcGroup = Get-ResourceGroupName
$certSecert = Get-CertAppSecretUrl
$res = Add-AzServiceFabricApplicationCertificate -ResourceGroupName $resourcGroup -Name $clusterName -SecretIdentifier $certSecert
Assert-NotNull $res.CertificateThumbprint
}

function Test-AddAzureRmServiceFabricApplicationCertificateRollback
{
$clusterName = Get-ClusterName
$resourcGroup = Get-ResourceGroupName
$certWU_SecretId = Get-CertWUSecretUrl

$exceptionThrown = $false
Try
{
$res = Add-AzureRmServiceFabricApplicationCertificate -ResourceGroupName $resourcGroup -Name $clusterName -SecretIdentifier $certWU_SecretId
}
Catch [System.Exception]
{
$Exception = $PSitem.Exception
while ($Exception.InnerException -ne $null)
{
$Exception = $Exception.InnerException
}

Assert-AreEqual $true ($Exception.Message -match 'is different from the location of the VM') ("unexpected error message: " + $Exception.Message )
$exceptionThrown = $true
}

Assert-AreEqual $true $exceptionThrown "Expected Exception keyvault in different location than VMSS not thrown"
}
3 changes: 1 addition & 2 deletions src/ServiceFabric/ServiceFabric/Az.ServiceFabric.psd1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ NestedModules = @('.\Microsoft.Azure.PowerShell.Cmdlets.ServiceFabric.dll')
FunctionsToExport = @()

# Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.
CmdletsToExport = 'Add-AzServiceFabricApplicationCertificate',
'Add-AzServiceFabricClientCertificate',
CmdletsToExport = 'Add-AzServiceFabricClientCertificate',
'Add-AzServiceFabricClusterCertificate', 'Add-AzServiceFabricNode',
'Add-AzServiceFabricNodeType', 'Get-AzServiceFabricCluster',
'New-AzServiceFabricCluster',
Expand Down
1 change: 1 addition & 0 deletions src/ServiceFabric/ServiceFabric/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Additional information about change #1
-->
## Upcoming Release
* Remove Add-AzServiceFabricApplicationCertificate cmdlet as this scenario is covered by Add-AzVmssSecret.

## Version 1.2.0
* Fixed typo in example for `Update-AzServiceFabricReliability` reference documentation
Expand Down
74 changes: 0 additions & 74 deletions src/ServiceFabric/ServiceFabric/Commands/AddAzureRmServiceFabricApplicationCertificate.cs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/ServiceFabric/ServiceFabric/Common/CmdletNoun.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ namespace Microsoft.Azure.Commands.ServiceFabric.Common
{
public static class CmdletNoun
{
public const string AzureRmServiceFabricApplicationCertificate = "AzureRmServiceFabricApplicationCertificate";
public const string AzureRmServiceFabricClientCertificate = "AzureRmServiceFabricClientCertificate";
public const string AzureRmServiceFabricClusterCertificate = "AzureRmServiceFabricClusterCertificate";
public const string AzureRmServiceFabricNode = "AzureRmServiceFabricNode";
Expand Down
Loading