Skip to content

Disable and enable sensitivity recommendations on columns in a database #10382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2019
Merged

Disable and enable sensitivity recommendations on columns in a database #10382

merged 3 commits into from
Oct 28, 2019

Conversation

bashahee
Copy link
Contributor

@bashahee bashahee commented Oct 24, 2019

Description

Customers will be able to disable (dismiss) or enable sensitivity recommendations on columns in their database. New tests were added in order to verify these changes.

Below issue was opened in order to get a design review:
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/379

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@bashahee
Copy link
Contributor Author

@msJinLei This was already reviewed in
#10382

bashahee and others added 2 commits October 27, 2019 15:48
@@ -27,6 +27,7 @@

## Version 1.15.0
* Add support for setting Active Directory Administrator on Managed Instance
* Adding cmdlets to Disable and enable sensitivity recommendations on columns in a database.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong place to put change log

@msJinLei msJinLei merged commit 5127415 into Azure:master Oct 28, 2019
@bashahee bashahee deleted the dataClassification branch December 23, 2019 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants