Skip to content

Fix SAS Token date format #10408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Conversation

apraovjr
Copy link
Contributor

@apraovjr apraovjr commented Oct 28, 2019

Description

Fix for SAS Token date format.
Issue: #10301

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@wyunchi-ms
Copy link
Contributor

Hi @apraovjr could you please add a test case for this?

@apraovjr
Copy link
Contributor Author

@wyunchi-ms The test case is already there, the fix is about changing the time format in existing command and also we are not testing the token which generates the time

@wyunchi-ms
Copy link
Contributor

@apraovjr Got it.

@wyunchi-ms wyunchi-ms merged commit 3bbb1c7 into Azure:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants