Skip to content

Fix the bug of PowerShellGet in tools/RunVersionController.ps1 #10412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

wyunchi-ms
Copy link
Contributor

@wyunchi-ms wyunchi-ms commented Oct 29, 2019

Description

  1. Fix the bug that can not find the right version PowerShellGet in some system.
  2. Make sure will not contain the moudle which's version is lower than 1.0.0. And remove used json files in SerializedCmdlets.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

…ome system.

2. Make sure will not contain the moudle which's version is lower than 1.0.0. And remove used json files in SerializedCmdlets.
@wyunchi-ms
Copy link
Contributor Author

#10053

@isra-fel isra-fel dismissed markcowl’s stale review November 21, 2019 07:16

Used #Requires -Modules ... to ensure powershellget version

@isra-fel isra-fel merged commit 600be09 into Azure:master Nov 21, 2019
@wyunchi-ms wyunchi-ms deleted the fix-RunVersionController branch November 15, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants