Added Policy API-version 2019-06-01. Policy assignment cmdlet updated to accept EnforcementMode property #10421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for new enforcementMode property
|
Can one of the admins verify this patch? |
sandipsh
changed the title
mentat9
reviewed
Oct 30, 2019
mentat9
reviewed
Oct 30, 2019
src/Resources/ResourceManager/Entities/Policy/EnforcementMode.cs
Outdated
Show resolved
Hide resolved
mentat9
previously approved these changes
Oct 30, 2019
|
@sandipsh please fix the failed test case |
mentat9
reviewed
Oct 31, 2019
src/Resources/ResourceManager/Implementation/Policy/PolicyHelpStrings.cs
Show resolved
Hide resolved
mentat9
reviewed
Oct 31, 2019
| @@ -12,6 +12,8 @@ | |||
| // limitations under the License. | |||
| // ---------------------------------------------------------------------------------- | |||
|
|
|||
| using System; | |||
There was a problem hiding this comment.
Move this inside the namespace.
mentat9
reviewed
Oct 31, 2019
src/Resources/ResourceManager/Implementation/Policy/SetAzurePolicyAssignment.cs
Show resolved
Hide resolved
mentat9
previously approved these changes
Oct 31, 2019
|
Addressed all comments and updated session record json file for failing test. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
msJinLei
reviewed
Nov 6, 2019
Remove the new version 1.7.2
msJinLei
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… for new enforcementMode property
Description
Updated Policy api version to 2019-06-01. Update New-AzPolicyAssignment and Set-AzPolicyAssignment cmdlets to accept -EnforcementMode parameter. Added test for the new property. Updated help and changelog. Also updated create policy definition help examples.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added