Skip to content

AzureRT PR #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Oct 5, 2015
Merged

AzureRT PR #1044

merged 37 commits into from
Oct 5, 2015

Conversation

hyonholee
Copy link
Contributor

ARM update:

  • Boot diagnostics feature:
    • Set-AzureRmBootDiagnostics cmdlet
    • Get-AzureRmBootDiagnosticsData cmdlet
    • New-AzureRmVM sets boot diagnostics enabled by default
  • Save-AzureRmVhd cmdlet

ASM update:

  • Fix for Get-AzureRemoteDesktopFile with Launch parameter
  • Update for New-AzureQuickVM: it creates a VM in an existing service even when location or affinity parameter is given.
  • Update for Remove-AzureVM: -WhatIf parameter support.

@hyonholee
Dev code for Save-AzureRMVhd cmdlet
1cfc107
@hyonholee
Add "None" value for Disk Caching.
64bfa31
@hyonholee
Fix the output of New-AzureRMVM and Update-AzureRMVM
faef27a
@hyonholee
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
3ec24ea
@hyonholee
Fix AzureRT test settings
d01407d
@hyonholee
Add -WhatIf to Remove-AzureVM
dd2b55a
@hyonholee
Fix AzureRT test issues due to the storage cmdlet name changes
94916b9
@hyonholee
Update New-AzureQuickVM
f0a258d 
such that it creates a vm with an existing service
when a location or an affinity group is given.
@hyonholee
Fix Get-AzureRemoteDesktopFile cmdlet with Launch parameter
6e2937f
@hyonholee
Fix Get-AzureRMRemoteDesktopFile
f917639
@hyonholee
Adding BootDiagnostics feature:
5be0fc7 
Set-AzureRMVMBootDiagnostics, Get-AzureVMBootDiagnosticsData
@hyonholee
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
752dd50 
Conflicts:
	src/ResourceManager/Compute/Commands.Compute/Common/ConstantStringTypes.cs
@hyonholee
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
e77f993
@hyonholee
Fix Get-AzureRMRemoteDesktopFile cmdlet
8185b5b
@hyonholee
Add boot diagnostic feature
89c26d7
@hyonholee
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
ce5ba4b
@hyonholee
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
c7659ca
@hyonholee
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
22e8990
@hyonholee
Merge branch 'dev' of https://github.com/hyonholee/azure-powershell i…
fd39b26 
…nto dev
@hyonholee
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
84558c9
@hyonholee
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
1a9e7bf
@hyonholee
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
f895f08
@hyonholee
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
ca5d5ab
@hyonholee
Add Save-AzureRMVhd Test
7c403c7
@hyonholee
Update New-AzureVM and Add tests for BootDiagnostics
2173bc4
@hyonholee
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
eebf8ed 
Conflicts:
	src/ResourceManager/Compute/Commands.Compute.Test/Commands.Compute.Test.csproj
	src/ResourceManager/Compute/Commands.Compute.Test/packages.config
	src/ResourceManager/Compute/Commands.Compute/packages.config
@hyonholee
Merge branch 'dev' of https://github.com/hyonholee/azure-powershell i…
e0ab966 
…nto dev

Conflicts:
	src/ResourceManager/Compute/Commands.Compute.Test/ScenarioTests/VirtualMachineTests.ps1
	src/ResourceManager/Compute/Commands.Compute.Test/packages.config
	src/ResourceManager/Compute/Commands.Compute/Properties/Resources.Designer.cs
	src/ResourceManager/Compute/Commands.Compute/Properties/Resources.resx
	src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/GetAzureVMBootDiagnosticsDataCommand.cs
	src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/NewAzureVMCommand.cs
	src/ResourceManager/Compute/Commands.Compute/packages.config
@hyonholee
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
85d304e
@hyonholee
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
68888c9 
Conflicts:
	src/ResourceManager/Compute/Commands.Compute.Test/ScenarioTests/VirtualMachineTests.ps1
@hyonholee
Revert skipMD5 hash parameter in Add-AzureVhd
a8a4581
@azurecla
Copy link

azurecla commented Oct 2, 2015

Hi @hyonholee, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (hylee). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

stankovski
stankovski reviewed Oct 2, 2015
View reviewed changes
src/ResourceManager/Compute/Commands.Compute/Common/ConstantStringTypes.cs
@@ -63,6 +69,8 @@ public static class ProfileNouns
public const string DataDisk = "AzureRmVMDataDisk";
public const string OSDisk = "AzureRmVMOSDisk";
public const string SourceImage = "AzureRmVMSourceImage";
public const string BootDiagnostics = "AzureRMVMBootDiagnostics";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be AzureRmXXX (lower-case m) everywhere

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@markcowl
Copy link
Member

markcowl commented Oct 3, 2015

@hyonholee Please sync to the latest and respond to feedback

@hyonholee
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
0525010 
Conflicts:
	src/ResourceManager/Compute/Commands.Compute.Test/packages.config
	src/ResourceManager/Compute/Commands.Compute/packages.config
huangpf
huangpf reviewed Oct 3, 2015
View reviewed changes
src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/NewAzureVMCommand.cs
@@ -45,10 +52,28 @@ protected override void ProcessRecord()
{
base.ProcessRecord();

if (this.VM.DiagnosticsProfile == null)
{
var storageUri = GetStorageAccountForBootDiagnostics();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetOrCreate ?

@markcowl
Copy link
Member

markcowl commented Oct 5, 2015

@hyonholee please sync to the latest

@hyonholee
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
a649695 
Conflicts:
	src/ResourceManager/Compute/Commands.Compute.Test/packages.config
	src/ResourceManager/Compute/Commands.Compute/packages.config
@stankovski
Copy link
Member

On demand: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-on-demand/218/

ogail added a commit that referenced this pull request Oct 5, 2015
@ogail
Merge pull request #1044 from hyonholee/dev
0570089 
AzureRT PR
@ogail ogail merged commit 0570089 into Azure:dev Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hyonholee @azurecla @markcowl @stankovski @huangpf @ogail