Skip to content

Add Find-Resource cmdlet and test/help file #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 2, 2015

Conversation

vivsriaus
Copy link
Contributor

No description provided.

@azurecla
Copy link

azurecla commented Oct 2, 2015

Hi @vivsriaus, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (visriniv). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

/// <summary>
/// Gets or sets the extension resource type.
/// </summary>
[Parameter(ParameterSetName = FindAzureResourceCmdlet.ListResourcesParameterSet, Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "The extension resource type. e.g. Microsoft.Sql/Servers/Databases.")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a better example in the help message. It is very difficult for the customer to differentiate between ResourceType and ExtensionResourceType by reading the current help message. If you could provide a different example and let the user know when to use what, that would be helpful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extension resource type is something that comes after the original/first resource type. For example: Microsoft.Sql/servers/testblahvivek23/databases/testdb2vivek123

I've added this example now, but this is something we'll need to fix across our cmdlets and make this more clearer in our help files. I'll send a separate PR for that.

@amarzavery
Copy link
Contributor

LGTM

@amarzavery
Copy link
Contributor

@vivsriaus - Your test is failing. http://azuresdkci.cloudapp.net/job/powershell/2859/artifact/src/Publish/TestResults/Microsoft.Azure.Commands.Resources.Test.html

Unable to find a matching record in the recordings file

amarzavery added a commit that referenced this pull request Oct 2, 2015
Add Find-Resource cmdlet and test/help file
@amarzavery amarzavery merged commit 5476ccf into Azure:dev Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants