Skip to content

Support MinimumTlsVersion property for Redis Cache cmdlets #10510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 14, 2019

Conversation

MECHANDR
Copy link
Contributor

@MECHANDR MECHANDR commented Nov 11, 2019

Added MinimumTlsVersion parameter in New-AzRedisCache and Set-AzRedisCache cmdlets. Also, added MinimumTlsVersion in the output of Get-AzRedisCache cmdlet. Fixes #9601 #9923

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@MECHANDR
Copy link
Contributor Author

MECHANDR commented Nov 12, 2019

Can someone help with build issues of running checks. PR doesn't have any changes which would have caused these errors.

C:\Program Files\dotnet\sdk\3.0.100\NuGet.targets(123,5): error : Response status code does not indicate success: 503 (Service Unavailable). [D:\a\1\s\tools\BuildPackagesTask\Microsoft.Azure.Build.Tasks\Microsoft.Azure.Build.Tasks.csproj] [D:\a\1\s\build.proj]
D:\a\1\s\build.proj(103,5): error MSB3073: The command "dotnet publish D:\a\1\s\tools/BuildPackagesTask/Microsoft.Azure.Build.Tasks/Microsoft.Azure.Build.Tasks.csproj -c Debug -f netstandard2.0" exited with code 1.
##[error]Error: The process 'C:\Program Files\dotnet\dotnet.exe' failed with exit code 1
##[error]Dotnet command failed with non-zero exit code on the following projects : ```

@msJinLei
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get-AzRedisCache does not return minimumTlsVersion where "az redis show" does
4 participants