Skip to content

Add new dns label #10523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Add new dns label #10523

merged 1 commit into from
Dec 6, 2019

Conversation

Cesarfgc
Copy link
Contributor

Add example to add a dns label to a public ip address

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

Add example to add a dns label to a public ip address
@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@msftclas
Copy link

msftclas commented Nov 12, 2019

CLA assistant check
All CLA requirements met.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cesarfgc thanks for the contribution 👍
@karravi-msft could you help review the example? Thanks!

@isra-fel isra-fel self-assigned this Nov 13, 2019
@isra-fel
Copy link
Member

kindly ping @@karravi-msft

@isra-fel
Copy link
Member

isra-fel commented Dec 5, 2019

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit 70fcabe into Azure:master Dec 6, 2019
@isra-fel
Copy link
Member

isra-fel commented Dec 9, 2019

Thanks for reviewing @number213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants