Skip to content

Changes to support "ReplicasPerMaster" and "Instances" #10659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 8, 2019

Conversation

MECHANDR
Copy link
Contributor

@MECHANDR MECHANDR commented Dec 4, 2019

Description

  • Added ReplicasPerMaster parameter in New-AzRedisCache cmdlet.
  • Added ReplicasPerMaster and Instances in the output of Get-AzRedisCache cmdlet.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly
Copy link
Collaborator

Hi @MECHANDR ,

please also add "Prerelease = 'preview'" in Az.RedisCache.psd1

@MECHANDR
Copy link
Contributor Author

MECHANDR commented Dec 5, 2019

Hi @MECHANDR ,
please also add "Prerelease = 'preview'" in Az.RedisCache.psd1

Added. Thanks.

@VeryEarly
Copy link
Collaborator

Hi @MECHANDR ,

TestZoneRedundancy.json failed at CredScan, looks like some response bodies contain passwords, ca you please take a look?

@VeryEarly VeryEarly merged commit f35e4d8 into master Dec 8, 2019
@wyunchi-ms wyunchi-ms deleted the redis_2019_07_01_preview branch May 19, 2020 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants