Update HDInsight cmdlets to persist values passed in -Config param

[ghost]

Update HDInsight cmdlets to persist values passed in -Config param

When doing a pipelined create like:

New-AzureHDInsightClusterConfig -ClusterType HBase -ClusterSizeInNodes 1 |
Set-AzureHDInsightDefaultStorage -StorageAccountName "MyStorage" -StorageAccountKey "MyKey" -StorageContainerName "MyContainer" |
Add-AzureHDInsightMetastore -SqlAzureServerName "MySqlServer" -DatabaseName "MyDb" -Credential $SomeCredential -MetastoreType HiveMetastore |
New-AzureHDInsightCluster -Credential $CluserCredentials -Name "MyNewCluster" -Location "North Europe" -Version "3.1"

The resulting cluster is created as a Hadoop cluster instead of HBase. It looks like this is the result of the cmdlet creating a new AzureHDInsightConfig in AddAzureHDInsightMetastoreCommand.cs but then neglecting to copy the ClusterType member in AddAzureHDInsightMetastoreCmdlet.cs

AddAzureHDInsightScriptActionCmdlet.cs is a more recently added cmdlet and has a comprehensive(currently) copy of the members of the passed-in Config parameter.

AddAzureHDInsightStorageCmdlet.cs and AddAzureHDInsightStorageCmdlet.cs had similar omissions.

This pull request copies the implementation from AddAzureHDInsightScriptActionCmdlet.cs to the three implementations that are missing fields. A better long-term solution might be to implement a copy constructor on the AzureHDInsightConfig class and just use that in each cmdlet implementation when you need to create a new Config that contains all of the fields of a passed-in Config. Let me know if you'd rather see that change and I can refactor.

This problem was originally reported through a support case, feel free to contact me (rickhall at microsoft.com) with any questions.

[azuresdkci]

Can one of the admins verify this patch?

[azurecla]

Hi @rickmsft, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

[ghost]

Do I need to sign the CLA even though I'm an FTE? (http://azure.github.io/guidelines.html#cla)

[stankovski]

@azuresdkci add to whitelist

[stankovski]

@rickmsft no, you don't need to sign the CLA

[ogail]

@azuresdkci retest this please

[shefaliv]

why are you removing all the null checks?

[ghost]

Implementation was copied from AddAzureHDInsightScriptActionCmdlet.cs. These values should reliably be non-null since the AzureHDInsightConfig constructor instantiates each member and the property setters are private.

[shefaliv]

Please shoot me an email at [email protected]. I handle PS on the HDI team. Thanks!