adding cmdlets for edge storage account and edge storage container #10763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
/azpsrun |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
msJinLei
suggested changes
Dec 25, 2019
...BoxEdge/DataBoxEdge/Common/Cmdlets/EdgeStorageAccounts/DataBoxEdgeStorageAccountNewCmdlet.cs
Show resolved
Hide resolved
| public string Name { get; set; } | ||
|
|
||
| [Parameter(Mandatory = true, | ||
| ParameterSetName = EdgeStorageAccountParameterSet, |
There was a problem hiding this comment.
For other parameters in this cmdlet, this property is omitted. why to specify here?
There was a problem hiding this comment.
Yep, this is not required, will remove it
...dge/DataBoxEdge/Common/Cmdlets/EdgeStorageContainers/DataBoxEdgeStorageContainerNewCmdlet.cs
Show resolved
Hide resolved
| @@ -237,7 +243,7 @@ private void ParseIotDeviceConnectionString() | |||
| this.iotDeviceAccessKey = deviceProperties.GetOrNull(SharedAccessKey); | |||
| this.iotDeviceHostHub = deviceProperties.GetOrNull(HostName); | |||
| } | |||
|
|
|||
src/DataBoxEdge/DataBoxEdge/Common/DataBoxEdgeResourceIdentifier.cs
Outdated
Show resolved
Hide resolved
src/DataBoxEdge/DataBoxEdge/Models/PSDataBoxEdgeNetworkAdapter.cs
Outdated
Show resolved
Hide resolved
msJinLei
approved these changes
Dec 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be addedDesign Issue