-
Notifications
You must be signed in to change notification settings - Fork 4k
Adding DataLake commands to RM #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check in data lake store and analytics Check in changes for HDI to use data lake Update everything to use my updated version of the authentication package (which includes data lake endpoints)
For publishing support until these are published.
add correct Auth package update PSAzureEnvironment to include DataLake endpoints Add datalake to the refactoring package.
There are bugs in private HDI that need to be fixed before being ported.
Update nuget packages and fix the client due to rename miss of DataLakeAccount -> DataLakeStoreAccount
Drop download chunk max size to 32mb fix the AzureResourceManager.psd1 to properly load sub psd1 files.
Can one of the admins verify this patch? |
Hi @begoldsm, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
@azuresdkci add to whitelist |
added "Store"
@begoldsm Need to enable nuget package restore for the new projects |
we already ensure that all paths start with a "/". this was adding another slash.
Backout visual studio package restore functionality.
this is using the new api versions
// Now do the conversion into a short | ||
var parsedShort = short.Parse(convertedPermissions); | ||
|
||
if (parsedShort < 0 || parsedShort > 777) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better defining const in vars: MinPort
, MaxPort
or similar
Add your tests dll to https://github.com/Azure/azure-powershell/blob/dev/AzurePowershell.Test.targets#L65 so it gets executed |
<HintPath>..\..\..\packages\Microsoft.Azure.Common.Authentication.1.3.3-preview\lib\net45\Microsoft.Azure.Common.Authentication.dll</HintPath> | ||
<Private>True</Private> | ||
<SpecificVersion>False</SpecificVersion> | ||
<HintPath>..\..\..\packages\Microsoft.Azure.Common.Authentication.1.4.1-preview\lib\net45\Microsoft.Azure.Common.Authentication.dll</HintPath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package with version 1.4.1
looks like its not published on NuGet, please make sure to:
- Have the change in https://github.com/Azure/azure-sdk-for-net/tree/AutoRest (this is AutoRest branch)
- Publish the package from there
- Update PowerShell PR to use the one published on NuGet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do that once my PR for AutoRest is published. The problem is that there are more changes that need to happen in PowerShell and autorest for that to work, since my package is based off version 1.3.3 and version 1.3.4 breaks the powershell. As a result, all my packages will be private until we are at a point where everything is properly published and ready to be upgraded in PowerShell.
Fixes for the uploader.
Fix bug in filtering for listing jobs Fix tests and include them for execution: NOTE: this is not a comprehensive suite, and more tests should be added here when there is time.
Fix move, join cmdlets to properly go to the right URI Optimize remove since ConfirmAction does the if/else work.
This includes the 30 second timeout for uploader operations. In the future this should be configurable, but for now if a store request takes longer than 30 seconds, it is considered a failure anyway.
This avoids conflicts when syncing from dev (hopefully).
This is the new version of the authentication SDK with data lake changes. The one that is being checked into the public repo will have this version, so the private one will just quit being used as soon as the new public one is published.
this avoids test failures due to unfound DLLs
This includes a change that makes the filesystem package testable and makes all requests ignore auto redirects for the data lake filesystem client.
@begoldsm As we discussed, please remove localFeed entities |
updated hdi sdk version and fixed build failures
removing the local feed since all packages are now live.
@begoldsm please fix test failures in on-demand job run. |
@begoldsm you most likely need to pull the latest from the dev branch for these to pass |
@begoldsm you will need to pull the latest. The fix for this was pushed a couple of hours ago. |
@azuresdkci retest this please |
Adding DataLake commands to RM
This change updates the Authentication package to the latest + DataLake endpoint changes.
It brings DataLake Store and DataLake Analytics cmdlets into the public repo
It uses the latest hyak.common which fixes a 500 error issue resulting in timeout.