Skip to content

Add cmdlets for Availability Group Listener resource of SqlVirtualMachine #10982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 4, 2020

Conversation

ranishan
Copy link
Contributor

@ranishan ranishan commented Jan 28, 2020

Description

Adding cmdlets for Availability Group Listener.
Cmdlet Design Review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/458

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@ranishan ranishan requested review from pratraw and yareyes January 28, 2020 10:27
Copy link
Collaborator

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add test cases for new classes

@ranishan
Copy link
Contributor Author

ranishan commented Feb 2, 2020

please also add test cases for new classes

Added test cases. Since the setup requires manual steps, I have recorded the tests with manually set resources

@VeryEarly VeryEarly merged commit 6b4f4a5 into Azure:master Feb 4, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
Add cmdlets for Availability Group Listener resource of SqlVirtualMachine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants