Skip to content

Remove range for Priority, handle empty name and remove by subnet/ip #10997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2020
Merged

Remove range for Priority, handle empty name and remove by subnet/ip #10997

merged 3 commits into from
Apr 1, 2020

Conversation

madsd
Copy link
Contributor

@madsd madsd commented Jan 30, 2020

Description

This PR will fix an issue where Priority Range was limited to 100-65000. There is no range limit in the backend.

It also addresses rule entries with empty names. To support this, changes had to be made to Add and Remove - specifically remove now contains optional IpAddress and Subnet/vNet parameters and logic to remove based on this input when supplied.

Help files has been updated to reflect this.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

markcowl
markcowl previously approved these changes Jan 31, 2020
@markcowl
Copy link
Member

@panchagnula can you please review and sign off on this change as aprpopriate?

panchagnula
panchagnula previously approved these changes Feb 11, 2020
@panchagnula
Copy link
Contributor

@madsd while you are looking at this can you fix this issue as well - I believe this is coming from the validation check #10794

@msJinLei
Copy link
Contributor

@madsd Could you resolve the conflicts? Thanks

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@madsd madsd dismissed stale reviews from panchagnula and markcowl via ffa0a9f March 31, 2020 13:43
@madsd
Copy link
Contributor Author

madsd commented Apr 1, 2020

@msJinLei Conflicts has been resolved

@msJinLei msJinLei merged commit d9dd75c into Azure:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants