Skip to content

Fix of example in Set-AzDiskKeyEncryptionKey and Set-AzDiskDiskEncryptionKey #11037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 19, 2020

Conversation

simonesavi
Copy link
Member

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

In the description of cmdlets Set-AzDiskKeyEncryptionKey and Set-AzDiskDiskEncryptionKey there is an example that, in case of disk restore, work well during the OS disk restore.

In case this operation will be done to restore a data disk, during the attachment of data disk to VM, the operation fail.
In order to fix this, an analysis was done with product group team. The outcome is that disk configuration must have a parameter that must be set in order to have data disk fully recovered.

I have tested the configuration for both OS and data disk, and it works without problem. For this configuration could be considered generic.

The procedure provided in example work only for OS. If you try to use the same command for data disk, mounting operation in Virtual Machine will fail. The fix it was discovered during an analysis with product group.
Provided example works only for OS disk. If you try to mount a data disk with this configuration, the operation fail. With setting inserted in example the problem is solved. The solution it was an outcome of an analysis done with Product Group
Fix broken example code for 'Set-AzDiskDiskEncryptionKey' and 'Set-AzDiskKeyEncryptionKey'
@simonesavi simonesavi requested a review from markcowl February 5, 2020 08:51
@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

Release branch for 2020-02-18 was already cut yesterday, In order to catch the release, cherry picked your commits in to another pr: #11108

add Sql to Network.sln
@VeryEarly VeryEarly merged commit 1262897 into master Feb 19, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
Fix of example in Set-AzDiskKeyEncryptionKey and Set-AzDiskDiskEncryptionKey
@wyunchi-ms wyunchi-ms deleted the simonesavi-patch-1 branch April 12, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants