Skip to content

Bug fixes for Azure Firewall #11067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2020
Merged

Conversation

iatodoro
Copy link
Contributor

@iatodoro iatodoro commented Feb 8, 2020

Description

Removing the ability to create management IP configuration outside of New/Allocate flows - attaching management IP config to an existing firewall is currently not supported. Updated docs accordingly.

Fixing bug where auto generated ipConfiguration names may conflict with existing ones

Fixing documentation bug for IpGroups

Checklist

  • The title of the PR is clear and informative
  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

… backend), fixing ipconfig naming conflict bug, fixing doc bugs
@iatodoro iatodoro requested a review from ssripadham February 8, 2020 19:55
@iatodoro iatodoro added this to the S165 (2020-02-18) milestone Feb 8, 2020
@iatodoro iatodoro requested a review from anton-evseev February 8, 2020 19:56
Copy link
Contributor

@anton-evseev anton-evseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please re-record updated test

@wyunchi-ms
Copy link
Contributor

Hi @iatodoro. As SetManagementIpConfiguration is a public method, so it may be used by the users, removing it may cause a breaking change. I suggest merge this on next Ignite release.

@iatodoro
Copy link
Contributor Author

Hi @iatodoro. As SetManagementIpConfiguration is a public method, so it may be used by the users, removing it may cause a breaking change. I suggest merge this on next Ignite release.

I think it's highly unlikely anyone is using this as it's part of a feature we haven't fully released yet. The backend implementation is specifically coded to prevent this scenario so this can be considered a bug fix. Currently if anyone does try to use this, they would get an API error and put their firewall in a bad state.

We are targetting 2/18 to release the feature, hence we need this fix in the S165 milestone.

@iatodoro
Copy link
Contributor Author

@number213 Updated recordings - please approve.

@iatodoro iatodoro merged commit 95792a1 into Azure:network-january Feb 11, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants