Skip to content

Update the resource group tag filter to use server side odata query #11128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 26, 2020

Conversation

hamidtirmizi
Copy link
Contributor

@hamidtirmizi hamidtirmizi commented Feb 15, 2020

Description

Get Resource Group cmdlet currently performs client side filtering of resource group, and it has a logic bug.

This PR removes client side filtering, and uses the now-supported server side filtering based on odata query.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@wyunchi-ms
Copy link
Contributor

Hi @hamidtirmizi how long does the test expect to cost? Do you need any help?

wyunchi-ms
wyunchi-ms previously approved these changes Feb 18, 2020
@wyunchi-ms wyunchi-ms dismissed their stale review February 18, 2020 02:28

Wrong operation

@hamidtirmizi
Copy link
Contributor Author

Tests added. PR ready for review.

@hamidtirmizi hamidtirmizi linked an issue Feb 20, 2020 that may be closed by this pull request
Tiano2017
Tiano2017 previously approved these changes Feb 20, 2020
Copy link
Contributor

@Tiano2017 Tiano2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hamidtirmizi
Copy link
Contributor Author

@wyunchi-ms please take a look

@wyunchi-ms wyunchi-ms merged commit d13c8e4 into master Feb 26, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
Update the resource group tag filter to use server side odata query
@Geraint87
Copy link

Can we have an example in the docs please? (Or even just here, to get started). I still don't think Get-AzResourceGroup with multiple tags works, or if so, I don't know how.
Example:
Get-AzResourceGroup -Tag @{AppId = "1"; Environment = "P"};
Response:
Invalid tag format. Expect @{tagName = $null} or @{tagName = "tagValue"}
Thanks!

@wyunchi-ms wyunchi-ms deleted the rgTagFilterOnServer branch January 10, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get-AzResourceGroup -Tag filter doesn't work with multiple tags
5 participants