-
Notifications
You must be signed in to change notification settings - Fork 4k
Update the resource group tag filter to use server side odata query #11128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @hamidtirmizi how long does the test expect to cost? Do you need any help? |
Tests added. PR ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wyunchi-ms please take a look |
src/Resources/Resources.Test/Models.ResourceGroups/ResourceClientTests.cs
Show resolved
Hide resolved
Update the resource group tag filter to use server side odata query
Can we have an example in the docs please? (Or even just here, to get started). I still don't think Get-AzResourceGroup with multiple tags works, or if so, I don't know how. |
Description
Get Resource Group cmdlet currently performs client side filtering of resource group, and it has a logic bug.
This PR removes client side filtering, and uses the now-supported server side filtering based on odata query.
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added