Skip to content

LTR MI cmdlets and tests #11192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Mar 5, 2020
Merged

LTR MI cmdlets and tests #11192

merged 30 commits into from
Mar 5, 2020

Conversation

xaliciayang
Copy link
Contributor

@xaliciayang xaliciayang commented Feb 26, 2020 •
edited
Loading

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@xaliciayang xaliciayang requested review from alcolic and pixia February 26, 2020 06:15
@wyunchi-ms wyunchi-ms self-assigned this Feb 26, 2020
@alcolic alcolic requested a review from djnisic February 26, 2020 18:41
@wyunchi-ms
Copy link
Contributor

Hi @xaliciayang could you please take a look at the CI? The build is failed.

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

pixia
pixia reviewed Feb 27, 2020
View reviewed changes
pixia
pixia reviewed Feb 27, 2020
View reviewed changes
pixia
pixia reviewed Feb 27, 2020
View reviewed changes
src/Sql/Sql.Test/Sql.Test.csproj Outdated
@@ -26,4 +26,10 @@
<ProjectReference Include="..\Sql\Sql.csproj" />
</ItemGroup>

<ItemGroup>
<Reference Include="Microsoft.Azure.Management.Sql">
<HintPath>..\..\..\..\azure-sdk-for-net\artifacts\bin\Microsoft.Azure.Management.Sql\Debug\net452\Microsoft.Azure.Management.Sql.dll</HintPath>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need version change after .net

pixia
pixia reviewed Feb 27, 2020
View reviewed changes
...ql/Sql/ManagedDatabase Backup/Cmdlet/RemoveAzureSqlManagedDatabaseLongTermRetentionBackup.cs Outdated
[Parameter(Mandatory = true,
ParameterSetName = RemoveBackupDefaultSet,
Position = 0,
HelpMessage = "The location of the backups' source server.")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instance or managed instance

pixia
pixia reviewed Feb 27, 2020
View reviewed changes
...ql/ManagedDatabase Backup/Model/AzureSqlManagedDatabaseBackupLongTermRetentionPolicyModel.cs Outdated
///// <param name="managedDatabaseName">Managed Instance name</param>
///// <param name="managedBackupRetentionPolicy">Managed Database object</param>
///// <param name="deletionDate">Deletion date of the database, if it is deleted</param>
//public AzureSqlManagedDatabaseBackupLongTermRetentionPolicyModel(string resourceGroup, string managedInstanceName, string managedDatabaseName, string weeklyRetention, string monthlyRetention, string yearlyRetention, int? weekOfYear)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove please, not used.

pixia
pixia reviewed Feb 27, 2020
View reviewed changes
src/Sql/Sql/ManagedDatabase Backup/Model/AzureSqlManagedDatabaseLongTermRetentionBackupModel.cs Outdated
public string ResourceId { get; set; }

/// <summary>
/// Gets or sets the server name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update description

pixia
pixia reviewed Mar 4, 2020
View reviewed changes
src/Sql/Sql/ChangeLog.md Outdated

## Version 2.3.0
* Added support for cross subscription point in time restore on Managed Instances.
* Add support for changing existing Sql Managed Instance hardware generation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

pixia
pixia reviewed Mar 4, 2020
View reviewed changes
src/Sql/Sql/ChangeLog.md Outdated
@@ -19,9 +19,15 @@
-->
## Upcoming Release
* Added PublicNetworkAccess to New-AzSqlServer and Set-AzSqlServer
* Added support for Long Term Retention services for Managed instances
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added support to manage Long Term Retention backups for Managed instances

@xaliciayang xaliciayang changed the base branch from master to release-2020-03-10 March 4, 2020 06:40
pixia
pixia reviewed Mar 4, 2020
View reviewed changes
src/Sql/Sql/help/Restore-AzSqlInstanceDatabase.md Outdated
-TargetInstanceDatabaseName <String> -TargetInstanceName <String> -TargetResourceGroupName <String> [-AsJob]
[-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
```

## DESCRIPTION
The **Restore-AzSqlInstanceDatabase** cmdlet restores an instance database from a geo-redundant backup or a point in time in a live database.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Restore-AzSqlInstanceDatabase cmdlet restores an instance database from a geo-redundant backup or a long term retention backup or a point in time in a live database.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

pixia
pixia previously approved these changes Mar 4, 2020
View reviewed changes
@wyunchi-ms
Copy link
Contributor

Hi @xaliciayang

  1. please donot remove tools/PS-VSPrompt.lnk.

wyunchi-ms
wyunchi-ms previously approved these changes Mar 4, 2020
View reviewed changes
@wyunchi-ms wyunchi-ms merged commit ec2a9a6 into Azure:release-2020-03-10 Mar 5, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
@wyunchi-ms
Merge pull request Azure#11192 from xaliciayang/ayang
125274d 
LTR MI cmdlets and tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyunchi-ms wyunchi-ms wyunchi-ms approved these changes

@pixia pixia pixia left review comments

@alcolic alcolic Awaiting requested review from alcolic

@djnisic djnisic Awaiting requested review from djnisic

Assignees

@wyunchi-ms wyunchi-ms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xaliciayang @wyunchi-ms @adxsdkps @pixia