Skip to content

Fix Remove-AzADGroup issue #11211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2020
Merged

Fix Remove-AzADGroup issue #11211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba5648b
Change default parameterset
dingmeng-xue Feb 28, 2020
3eba888
update changelog.md
dingmeng-xue Feb 28, 2020
fd6a671
exclude breaking change issue
dingmeng-xue Feb 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Resources/Resources/ActiveDirectory/Cmdlets/RemoveAzureADGroupCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

namespace Microsoft.Azure.Commands.ActiveDirectory
{
[Cmdlet("Remove", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "ADGroup", SupportsShouldProcess = true, DefaultParameterSetName = ParameterSet.ObjectId), OutputType(typeof(bool))]
[Cmdlet("Remove", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "ADGroup", SupportsShouldProcess = true, DefaultParameterSetName = ParameterSet.DisplayName), OutputType(typeof(bool))]
public class RemoveAzureADGroupCommand : ActiveDirectoryBaseCmdlet
{
[Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.ObjectId, HelpMessage = "The object id of the group to be removed.")]
Expand Down
9 changes: 5 additions & 4 deletions src/Resources/Resources/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,11 @@
-->
## Upcoming Release
* Fixed for null reference bug in `Get-AzRoleAssignment`
* Marked switch `-Force` and `-PassThru` optional in `Remove-AzADGroup` (#10849)
* Fixed issue that `MailNickname` doesn't return in `Remove-AzADGroup` (#11167)
* Fix for null reference bug in GetAzureRoleAssignmentCommand
* Add breaking change attributes for upcoming changes to policy cmdlets
* Marked switch `-Force` and `-PassThru` optional in `Remove-AzADGroup` [#10849]
* Fixed issue that `MailNickname` doesn't return in `Remove-AzADGroup` [#11167]
* Fixed issue that `Remove-AzADGroup` pipe operation doesn't work [#11171]
* Fixed for null reference bug in GetAzureRoleAssignmentCommand
* Added breaking change attributes for upcoming changes to policy cmdlets
* Updated `Get-AzResourceGroup` to perform resource group tag filtering on server-side
* Extended Tag cmdlets to accept -ResourceId
- Get-AzTag -ResourceId
Expand Down
3 changes: 2 additions & 1 deletion tools/StaticAnalysis/Exceptions/Az.Resources/BreakingChangeIssues.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,5 @@
"Microsoft.Azure.PowerShell.Cmdlets.ResourceManager.Cmdlets.dll","Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation.SetAzurePolicyAssignmentCmdlet","Set-AzPolicyAssignment","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Set-AzPolicyAssignment' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Set-AzPolicyAssignment'."
"Microsoft.Azure.PowerShell.Cmdlets.ResourceManager.Cmdlets.dll","Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation.SetAzurePolicyAssignmentCmdlet","Set-AzPolicyAssignment","0","1050","The parameter set 'IdParameterSet' for cmdlet 'Set-AzPolicyAssignment' has been removed.","Add parameter set 'IdParameterSet' back to cmdlet 'Set-AzPolicyAssignment'."
"Microsoft.Azure.PowerShell.Cmdlets.Resources.dll","Microsoft.Azure.Commands.ActiveDirectory.NewAzureADUserCommand","New-AzADUser","0","1050","The parameter set '__AllParameterSets' for cmdlet 'New-AzADUser' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'New-AzADUser'."
"Microsoft.Azure.PowerShell.Cmdlets.ResourceManager.dll","Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation.GetAzureDeploymentCmdlet","Get-AzDeployment","0","1050","The parameter set 'GetByDeploymentId' for cmdlet 'Get-AzDeployment' has been removed.","Add parameter set 'GetByDeploymentId' back to cmdlet 'Get-AzDeployment'."
"Microsoft.Azure.PowerShell.Cmdlets.ResourceManager.dll","Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation.GetAzureDeploymentCmdlet","Get-AzDeployment","0","1050","The parameter set 'GetByDeploymentId' for cmdlet 'Get-AzDeployment' has been removed.","Add parameter set 'GetByDeploymentId' back to cmdlet 'Get-AzDeployment'."
"Microsoft.Azure.PowerShell.Cmdlets.Resources.dll","Microsoft.Azure.Commands.ActiveDirectory.RemoveAzureADGroupCommand","Remove-AzADGroup","0","1060","The parameter set 'ObjectIdParameterSet' for cmdlet 'Remove-AzADGroup' is no longer the default parameter set.","Change the default parameter for cmdlet 'Remove-AzADGroup' back to 'ObjectIdParameterSet'."