Skip to content

[HDInsight] Support customers specify min TLS version when creating cluster #11344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2020
Merged

[HDInsight] Support customers specify min TLS version when creating cluster #11344

merged 1 commit into from
Mar 20, 2020

Conversation

aim-for-better
Copy link
Member

@aim-for-better aim-for-better commented Mar 17, 2020 •
edited
Loading

Description

  1. Support customers specify min TLS version when creating cluster
  2. Update help and test

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@isra-fel isra-fel self-assigned this Mar 18, 2020
isra-fel
isra-fel requested changes Mar 20, 2020
View reviewed changes
src/HDInsight/HDInsight/ManagementCommands/NewAzureHDInsightClusterConfigCommand.cs
@@ -148,6 +148,13 @@ public Guid AadTenantId
set { _config.AADTenantId = value; }
}

[Parameter(HelpMessage = "Gets or sets the minimal supported TLS version.")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help doc for this cmdlet needs to be regenerated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help doc for this cmdlet needs to be regenerated

Updated

@isra-fel isra-fel assigned aim-for-better and unassigned isra-fel Mar 20, 2020
@aim-for-better aim-for-better added this to the S167 (2020-03-31) milestone Mar 20, 2020
@aim-for-better aim-for-better force-pushed the AddMinSupportedTlsVersion branch from 919e7be to 06f9731 Compare March 20, 2020 05:28
@aim-for-better aim-for-better requested a review from isra-fel March 20, 2020 05:30
isra-fel
isra-fel approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit 01aa111 into Azure:master Mar 20, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
@isra-fel
Merge pull request Azure#11344 from aim-for-better/AddMinSupportedTls…
e234ff5 
…Version

[HDInsight] Support customers specify min TLS version when creating cluster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

Assignees

@aim-for-better aim-for-better

Labels
needs-revision
Projects
None yet
Milestone
S167 (2020-03-31)
Development

Successfully merging this pull request may close these issues.
2 participants
@aim-for-better @isra-fel