Skip to content

Added option of Byte encoding for New-AzDataLakeStoreItem, Add-AzDAtaLakeStoreItemContent, Get-AzDAtaLakeStoreItemContent #11355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2020

Conversation

rahuldutta90
Copy link
Contributor

Added option of Byte encoding for New-AzDataLakeStoreItem, Add-AzDAtaLakeStoreItemContent, Get-AzDAtaLakeStoreItemContent. Fixes #11018

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

…LakeStoreItemContent, Get-AzDAtaLakeStoreItemContent
@rahuldutta90 rahuldutta90 requested a review from akharit March 18, 2020 02:36
@rahuldutta90 rahuldutta90 added this to the S167 (2020-03-31) milestone Mar 18, 2020
@rahuldutta90
Copy link
Contributor Author

@isra-fel isra-fel self-assigned this Mar 18, 2020
@@ -66,13 +66,13 @@ public void TestAdlsAccountTiers()
NewInstance.RunPsTest(_logger, string.Format("Test-DataLakeStoreAccountTiers -location '{0}'", AdlsTestsBase.ResourceGroupLocation));
}

[Fact(Skip="This case has been unstable on Linux for approximately 20% of failure. Needs investigation.")]
[Fact(Skip = "This case has been unstable on Linux for approximately 20% of failure. Needs investigation.")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case was previously skipped because it fails randomly in Linux environment. Details are in #10667
Please enable it and fix the error. Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isra-fel I did see you skipped it, however i could not reproduce it in my linux VM. So I still do not understand the exact root cause of it, however i feel why it might be happening. But thing is the failure is for adlsaliastest and you have skipped it for adlstest.

Now if you see there are two versions of test AdlsAliasTest and AdlsTest. Both are exact replicas functionally, only difference is one of them uses alias commandlet names. And in most of the logs i see "Export-AdlStoreChildItemProperties" failing for alias. As a part of this commandlet we write output to a local path. So i suspect adlstest and adlsaliastest are interfering with each other. Reason why i think is because adlsaliastest was the one failng, but you disabled adlstest and it started passing more. I still do not know why they are interfering.

What I will do is try to comment out "Export-AdlStoreChildItemProperties" in adlsaliastest.testfilesystem (since thats the one failing) and enable the adlstest.testfilesystem. But I dont think this PR is the correct place to fix this since this adresses a different bug.

I will send out a different PR after this with the proposed change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your explanation, it makes sense to me.

@isra-fel isra-fel merged commit 624fd79 into master Mar 23, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
Added option of Byte encoding for New-AzDataLakeStoreItem, Add-AzDAtaLakeStoreItemContent, Get-AzDAtaLakeStoreItemContent
@wyunchi-ms wyunchi-ms deleted the task-fix-byteencodingadls branch January 10, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Az.DataLakeStore New-AzDataLakeStoreItem doesn't allow uploading Byte[] content
3 participants