-
Notifications
You must be signed in to change notification settings - Fork 4k
Added option of Byte encoding for New-AzDataLakeStoreItem, Add-AzDAtaLakeStoreItemContent, Get-AzDAtaLakeStoreItemContent #11355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…LakeStoreItemContent, Get-AzDAtaLakeStoreItemContent
src/DataLakeStore/DataLakeStore/DataPlaneModels/DataLakeStoreFileSystemCmdletBase.cs
Show resolved
Hide resolved
@@ -66,13 +66,13 @@ public void TestAdlsAccountTiers() | |||
NewInstance.RunPsTest(_logger, string.Format("Test-DataLakeStoreAccountTiers -location '{0}'", AdlsTestsBase.ResourceGroupLocation)); | |||
} | |||
|
|||
[Fact(Skip="This case has been unstable on Linux for approximately 20% of failure. Needs investigation.")] | |||
[Fact(Skip = "This case has been unstable on Linux for approximately 20% of failure. Needs investigation.")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case was previously skipped because it fails randomly in Linux environment. Details are in #10667
Please enable it and fix the error. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isra-fel I did see you skipped it, however i could not reproduce it in my linux VM. So I still do not understand the exact root cause of it, however i feel why it might be happening. But thing is the failure is for adlsaliastest and you have skipped it for adlstest.
Now if you see there are two versions of test AdlsAliasTest and AdlsTest. Both are exact replicas functionally, only difference is one of them uses alias commandlet names. And in most of the logs i see "Export-AdlStoreChildItemProperties" failing for alias. As a part of this commandlet we write output to a local path. So i suspect adlstest and adlsaliastest are interfering with each other. Reason why i think is because adlsaliastest was the one failng, but you disabled adlstest and it started passing more. I still do not know why they are interfering.
What I will do is try to comment out "Export-AdlStoreChildItemProperties" in adlsaliastest.testfilesystem (since thats the one failing) and enable the adlstest.testfilesystem. But I dont think this PR is the correct place to fix this since this adresses a different bug.
I will send out a different PR after this with the proposed change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your explanation, it makes sense to me.
Added option of Byte encoding for New-AzDataLakeStoreItem, Add-AzDAtaLakeStoreItemContent, Get-AzDAtaLakeStoreItemContent
Added option of Byte encoding for New-AzDataLakeStoreItem, Add-AzDAtaLakeStoreItemContent, Get-AzDAtaLakeStoreItemContent. Fixes #11018
Description
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added