[ASR] [V2A] Adding properties for VMware DR monitoring #11360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
isra-fel
requested changes
Mar 18, 2020
isra-fel
reviewed
Mar 18, 2020
| @@ -117,6 +117,14 @@ public ASRProcessServer(ProcessServer processServer) | |||
| this.SystemLoadStatus = processServer.SystemLoadStatus; | |||
| this.TotalMemoryInBytes = processServer.TotalMemoryInBytes; | |||
| this.TotalSpaceInBytes = processServer.TotalSpaceInBytes; | |||
| this.Health = processServer.Health; | |||
There was a problem hiding this comment.
and also update existing tests to test these new properties
There was a problem hiding this comment.
The infrastructure used in previous tests is not present anymore. To add the new properties, I need to add the new infra. Will take this up in separate PR.
Updated ChangeLog.md |
dingmeng-xue
pushed a commit
to dingmeng-xue/azure-powershell
that referenced
this pull request
Mar 29, 2020
…ringChanges [ASR] [V2A] Adding properties for VMware DR monitoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added properties for Process server in GetAsrFabric and process server name in GetAsrProtectedItem
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added