Skip to content

Network release #11379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Mar 20, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
2c56be4
disconnect vpn connection for vng/p2svpn
ninweninwe Jan 23, 2020
9fff0e5
tests, help doc
ninweninwe Jan 23, 2020
1b17c5b
update helps
ninweninwe Jan 24, 2020
8a875c2
update ps tests
ninweninwe Jan 25, 2020
51a2124
test vng disconnect vpn connection
ninweninwe Jan 27, 2020
c646fff
disconn p2s vpn gw vpn connection
ninweninwe Jan 28, 2020
45d5f52
update help
ninweninwe Jan 28, 2020
a3e58e2
update test records
ninweninwe Jan 29, 2020
06ec362
update
ninweninwe Jan 29, 2020
564bd6c
update test
ninweninwe Jan 29, 2020
cd3f3eb
Merge branch 'network-january' into network-december
ninweninwe Feb 4, 2020
bc1d83f
Removing ability to create new management IP config (not supported in…
iatodoro Feb 8, 2020
7cf7748
Fix wrong heading level in help file
iatodoro Feb 8, 2020
cc44359
update change log
ninweninwe Feb 10, 2020
821ad04
Updating test recordings for management ipconfig
iatodoro Feb 10, 2020
a5af35a
Merge pull request #11031 from ninweninwe/network-december
ninweninwe Feb 11, 2020
2c1fd4a
Unskip and re-record ExpressRoutePort tests
v-shhatt Feb 11, 2020
95792a1
Merge pull request #11067 from iatodoro/azfw_forcetun_fix
iatodoro Feb 11, 2020
3218af4
Merge pull request #11100 from v-shhatt/ExpressRoutePortTests
anton-evseev Feb 12, 2020
305d56a
update disconnect vpn/p2svpn gateway vpn connections
ninweninwe Feb 12, 2020
6ac5e93
update disconnect vpn/p2svpn gateway vpn connections
ninweninwe Feb 12, 2020
2c7eb17
fix help file
ninweninwe Feb 13, 2020
f913ab5
Merge pull request #11111 from ninweninwe/network-january
VeryEarly Feb 14, 2020
a6055f7
Change the min limit for scale units
vinayada1 Feb 24, 2020
7014e6a
Added new cmdlets for flowLog resource
irrogozh Feb 26, 2020
85782f7
Added tests, help files + fixes based on CR
irrogozh Feb 27, 2020
7ac79da
Added online version to help files for flowLogs cmdlets
irrogozh Feb 27, 2020
dbc622c
Merge pull request #11193 from irrogozh/network-january
wyunchi-ms Mar 1, 2020
bd3f1e1
Merge pull request #11182 from vinayada1/minScaleUnitsFix
wyunchi-ms Mar 1, 2020
c7f4137
Minor helper file fix
Nilambari Mar 11, 2020
5064272
Merge pull request #11299 from Nilambari/netowrk-jan2020
Nilambari Mar 11, 2020
95da0b1
Update Network SDK & test recordings
anton-evseev Mar 10, 2020
175ce09
AppGw recordings
anton-evseev Mar 18, 2020
0aa423d
Update
anton-evseev Mar 18, 2020
6224c0b
CredSan suppression
anton-evseev Mar 18, 2020
33c7b0c
Merge pull request #11346 from number213/network-2019-12-01
isra-fel Mar 18, 2020
c9c481d
Merge branch 'network-january' into merge-network-january
anton-evseev Mar 20, 2020
95c7f7e
Fix after merge
anton-evseev Mar 20, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<PsModuleName>CognitiveServices</PsModuleName>
Expand All @@ -12,7 +12,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.Azure.Management.CognitiveServices" Version="7.0.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.Network" Version="19.18.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.Network" Version="19.19.0-preview" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion src/Compute/Compute.Test/Compute.Test.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<PackageReference Include="Microsoft.Azure.Graph.RBAC" Version="3.4.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="33.0.0" />
<PackageReference Include="Microsoft.Azure.Management.KeyVault" Version="2.4.2" />
<PackageReference Include="Microsoft.Azure.Management.Network" Version="19.18.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.Network" Version="19.19.0-preview" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.Azure.Management.DataLake.Store" Version="2.4.2-preview" />
<PackageReference Include="Microsoft.Azure.Management.Network" Version="19.18.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.Network" Version="19.19.0-preview" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/Dns/Dns.Test/Dns.Test.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.Azure.Management.Dns" Version="3.0.1" />
<PackageReference Include="Microsoft.Azure.Management.Network" Version="19.18.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.Network" Version="19.19.0-preview" />
</ItemGroup>

</Project>

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/KeyVault/KeyVault.Test/KeyVault.Test.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<PackageReference Include="Microsoft.Azure.KeyVault" Version="3.0.1" />
<PackageReference Include="Microsoft.Azure.KeyVault.WebKey" Version="3.0.1" />
<PackageReference Include="Microsoft.Azure.Management.KeyVault" Version="2.4.2" />
<PackageReference Include="Microsoft.Azure.Management.Network" Version="19.18.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.Network" Version="19.19.0-preview" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/NetAppFiles/NetAppFiles.Test/NetAppFiles.Test.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.Azure.Management.NetApp" Version="1.3.0" />
<PackageReference Include="Microsoft.Azure.Management.Network" Version="19.18.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.Network" Version="19.19.0-preview" />
</ItemGroup>

</Project>

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/Network/Network.Test/Network.Test.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.Azure.Graph.RBAC" Version="3.4.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.Network" Version="19.18.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.Network" Version="19.19.0-preview" />
<PackageReference Include="Microsoft.Azure.Insights" Version="0.16.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="33.0.0" />
<PackageReference Include="Microsoft.Azure.Management.ContainerInstance" Version="2.0.0" />
Expand Down
5 changes: 5 additions & 0 deletions src/Network/Network.Test/NrpTeamAlias.cs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ class NrpTeamAlias
// Below is the list of aliases to contact on test behavior

// Virtual Appliance dev team
// First part of ApplicationGateway tests
public const string nvadev = "nvadev";
// Second part of ApplicationGateway tests
public const string nvadev_subset1 = "nvadev_subset1";

// SDN NRP Dev Team
public const string sdnnrp = "sdnnrp";
Expand All @@ -42,6 +45,8 @@ class NrpTeamAlias
public const string brooklynft_subset3 = "brooklynft_subset3";
// Second part of VirtualNetworkGatewayConnection tests
public const string brooklynft_subset4 = "brooklynft_subset4";
// Third part of VirtualNetworkGatewayConnection tests
public const string brooklynft_subset5 = "brooklynft_subset5";

// Azure Network Analytics Dev Team
public const string netanalyticsdev = "netanalyticsdev";
Expand Down
22 changes: 11 additions & 11 deletions src/Network/Network.Test/ScenarioTests/ApplicationGatewayTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -85,54 +85,54 @@ public void TestApplicationGatewayCRUDSubItems2()
[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
[Trait(Category.Owner, NrpTeamAlias.nvadev)]
public void TestApplicationGatewayCRUDRewriteRuleSet()
public void TestAvailableServerVariableAndHeader()
{
TestRunner.RunTestScript(string.Format("Test-ApplicationGatewayCRUDRewriteRuleSet -baseDir '{0}'", AppDomain.CurrentDomain.BaseDirectory));
TestRunner.RunTestScript("Test-AvailableServerVariableAndHeader");
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
[Trait(Category.Owner, NrpTeamAlias.nvadev)]
public void TestAvailableServerVariableAndHeader()
[Trait(Category.Owner, NrpTeamAlias.nvadev_subset1)]
public void TestApplicationGatewayCRUDRewriteRuleSet()
{
TestRunner.RunTestScript("Test-AvailableServerVariableAndHeader");
}
TestRunner.RunTestScript(string.Format("Test-ApplicationGatewayCRUDRewriteRuleSet -baseDir '{0}'", AppDomain.CurrentDomain.BaseDirectory));
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
[Trait(Category.Owner, NrpTeamAlias.nvadev)]
[Trait(Category.Owner, NrpTeamAlias.nvadev_subset1)]
public void TestApplicationGatewayCRUDRewriteRuleSetWithConditions()
{
TestRunner.RunTestScript(string.Format("Test-ApplicationGatewayCRUDRewriteRuleSetWithConditions -baseDir '{0}'", AppDomain.CurrentDomain.BaseDirectory));
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
[Trait(Category.Owner, NrpTeamAlias.nvadev)]
[Trait(Category.Owner, NrpTeamAlias.nvadev_subset1)]
public void TestTopLevelWafResourceWithApplicationGateway()
{
TestRunner.RunTestScript(string.Format("Test-ApplicationGatewayTopLevelFirewallPolicy -baseDir '{0}'", AppDomain.CurrentDomain.BaseDirectory));
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
[Trait(Category.Owner, NrpTeamAlias.nvadev)]
[Trait(Category.Owner, NrpTeamAlias.nvadev_subset1)]
public void TestApplicationGatewayWithFirewallPolicy()
{
TestRunner.RunTestScript(string.Format("Test-ApplicationGatewayWithFirewallPolicy -baseDir '{0}'", AppDomain.CurrentDomain.BaseDirectory));
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
[Trait(Category.Owner, NrpTeamAlias.nvadev)]
[Trait(Category.Owner, NrpTeamAlias.nvadev_subset1)]
public void TestApplicationGatewayCRUDRewriteRuleSetUrlConfiguration()
{
TestRunner.RunTestScript(string.Format("Test-ApplicationGatewayCRUDRewriteRuleSetWithUrlConfiguration -baseDir '{0}'", AppDomain.CurrentDomain.BaseDirectory));
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
[Trait(Category.Owner, NrpTeamAlias.nvadev)]
[Trait(Category.Owner, NrpTeamAlias.nvadev_subset1)]
public void TestApplicationGatewayWithListenerHostNames()
{
TestRunner.RunTestScript(string.Format("Test-ApplicationGatewayWithListenerHostNames -baseDir '{0}'", AppDomain.CurrentDomain.BaseDirectory));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2407,7 +2407,7 @@ function Test-ApplicationGatewayWithFirewallPolicy
{
# The Per-Site firewall policy can only be enabled in regions which have the dynamic setting set to true.
# Currently Central US EUAP region has it enabled so hardcoding it to this region, This can be removed once it is enabled on regions in production.
$location = "centraluseuap"
$location = "westus"
$resourceGroup = New-AzResourceGroup -Name $rgname -Location $location -Tags @{ testtag = "APPGw tag"}
# Create the Virtual Network
$gwSubnet = New-AzVirtualNetworkSubnetConfig -Name $gwSubnetName -AddressPrefix 10.0.0.0/24
Expand Down
13 changes: 3 additions & 10 deletions src/Network/Network.Test/ScenarioTests/AzureFirewallTests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -998,7 +998,7 @@ function Test-AzureFirewallCRUDwithManagementIpConfig {
$rgname = Get-ResourceGroupName
$azureFirewallName = Get-ResourceName
$resourceTypeParent = "Microsoft.Network/AzureFirewalls"
$location = Get-ProviderLocation $resourceTypeParent "centraluseuap"
$location = Get-ProviderLocation $resourceTypeParent "eastus2euap"

$vnetName = Get-ResourceName
$subnetName = "AzureFirewallSubnet"
Expand Down Expand Up @@ -1056,21 +1056,14 @@ function Test-AzureFirewallCRUDwithManagementIpConfig {
Assert-ThrowsContains { $getAzureFirewall.AddPublicIpAddress("ABCD") } "Cannot convert argument"
Assert-ThrowsContains { $getAzureFirewall.AddPublicIpAddress($publicip1) } "already attached to firewall"

# Test handling of incorrect values when setting management IP configuration
Assert-ThrowsContains { $getAzureFirewall.SetManagementIpConfiguration() } "Cannot find an overload"
Assert-ThrowsContains { $getAzureFirewall.SetManagementIpConfiguration($null) } "Cannot find an overload"
Assert-ThrowsContains { $getAzureFirewall.SetManagementIpConfiguration($null, $mgmtPublicIp) } "Virtual Network cannot be null"
Assert-ThrowsContains { $getAzureFirewall.SetManagementIpConfiguration("ABCD", "ABCDE") } "Cannot convert argument"


# Test handling of incorrect values when removing public IP Address
Assert-ThrowsContains { $getAzureFirewall.RemovePublicIpAddress() } "Cannot find an overload"
Assert-ThrowsContains { $getAzureFirewall.RemovePublicIpAddress($null) } "Public IP Address cannot be null"
Assert-ThrowsContains { $getAzureFirewall.RemovePublicIpAddress("ABCD") } "Cannot convert argument"
Assert-ThrowsContains { $getAzureFirewall.RemovePublicIpAddress($mgmtPublicIp) } "not attached to firewall"

# Change management public IP address
$getAzureFirewall.SetManagementIpConfiguration($vnet, $mgmtPublicIp2)
# Change Management PIP
$getAzureFirewall.ManagementIpConfiguration.PublicIpAddress = $mgmtPublicIp2

# Set AzureFirewall
Set-AzFirewall -AzureFirewall $getAzureFirewall
Expand Down
8 changes: 8 additions & 0 deletions src/Network/Network.Test/ScenarioTests/CortexTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -58,5 +58,13 @@ public void TestP2SCortexCRUD()
{
TestRunner.RunTestScript("Test-P2SCortexCRUD");
}

[Fact]
[Trait(Category.AcceptanceType, Category.LiveOnly)]
[Trait(Category.Owner, NrpTeamAlias.brooklynft)]
public void TestDisconnectAzP2sVpnGatewayVpnConnection()
{
TestRunner.RunTestScript("Test-DisconnectAzP2sVpnGatewayVpnConnection");
}
}
}
83 changes: 83 additions & 0 deletions src/Network/Network.Test/ScenarioTests/CortexTests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -683,6 +683,89 @@ function Test-CortexExpressRouteCRUD
$delete = Remove-AzVirtualWan -InputObject $virtualWan -Force -PassThru
Assert-AreEqual $True $delete

Clean-ResourceGroup $rgname
}
}

<#
.SYNOPSIS
Disconnect Point to site vpn gateway vpn connection
#>
function Test-DisconnectAzP2sVpnGatewayVpnConnection
{
param
(
$basedir = ".\"
)

# Setup
$rgname = Get-ResourceGroupName
$rglocation = "East US"

$virtualWanName = Get-ResourceName
$virtualHubName = Get-ResourceName
$VpnServerConfiguration1Name = Get-ResourceName
$P2SVpnGatewayName = Get-ResourceName

try
{
# Create the resource group
New-AzResourceGroup -Name $rgname -Location $rglocation

# Create the Virtual Wan
New-AzVirtualWan -ResourceGroupName $rgName -Name $virtualWanName -Location $rglocation
$virtualWan = Get-AzVirtualWan -ResourceGroupName $rgName -Name $virtualWanName
Assert-AreEqual $virtualWanName $virtualWan.Name

# Create the Virtual Hub
New-AzVirtualHub -ResourceGroupName $rgName -Name $virtualHubName -Location $rglocation -AddressPrefix "192.168.1.0/24" -VirtualWan $virtualWan
$virtualHub = Get-AzVirtualHub -ResourceGroupName $rgName -Name $virtualHubName
Assert-AreEqual $virtualHubName $virtualHub.Name
Assert-AreEqual $virtualWan.Id $virtualhub.VirtualWan.Id

# Create the VpnServerConfiguration1 with VpnClient settings using New-AzVpnServerConfiguration
$VpnServerConfigCertFilePath = Join-Path -Path $basedir -ChildPath "\ScenarioTests\Data\ApplicationGatewayAuthCert.cer"
$listOfCerts = New-Object "System.Collections.Generic.List[String]"
$listOfCerts.Add($VpnServerConfigCertFilePath)
$vpnclientipsecpolicy1 = New-AzVpnClientIpsecPolicy -IpsecEncryption AES256 -IpsecIntegrity SHA256 -SALifeTime 86471 -SADataSize 429496 -IkeEncryption AES256 -IkeIntegrity SHA384 -DhGroup DHGroup14 -PfsGroup PFS14
New-AzVpnServerConfiguration -Name $VpnServerConfiguration1Name -ResourceGroupName $rgName -VpnProtocol IkeV2 -VpnAuthenticationType Certificate -VpnClientRootCertificateFilesList $listOfCerts -VpnClientRevokedCertificateFilesList $listOfCerts -VpnClientIpsecPolicy $vpnclientipsecpolicy1 -Location $rglocation

# Get created VpnServerConfiguration using Get-AzVpnServerConfiguration
$vpnServerConfig1 = Get-AzVpnServerConfiguration -ResourceGroupName $rgName -Name $VpnServerConfiguration1Name
Assert-NotNull $vpnServerConfig1

# Create the P2SVpnGateway using New-AzP2sVpnGateway
$vpnClientAddressSpaces = New-Object string[] 2
$vpnClientAddressSpaces[0] = "192.168.2.0/24"
$vpnClientAddressSpaces[1] = "192.168.3.0/24"
New-AzP2sVpnGateway -ResourceGroupName $rgName -Name $P2SvpnGatewayName -VirtualHub $virtualHub -VpnGatewayScaleUnit 1 -VpnClientAddressPool $vpnClientAddressSpaces -VpnServerConfiguration $vpnServerConfig1

# Get the created P2SVpnGateway using Get-AzP2sVpnGateway
$P2SVpnGateway = Get-AzP2sVpnGateway -ResourceGroupName $rgName -Name $P2SvpnGatewayName
Assert-AreEqual $P2SvpnGatewayName $P2SVpnGateway.Name
Assert-AreEqual "Succeeded" $P2SVpnGateway.ProvisioningState

$expected = Disconnect-AzP2SVpnGatewayVpnConnection -ResourceGroupName $rgname -ResourceName $P2SvpnGatewayName -VpnConnectionId @("IKEv2_1e1cfe59-5c7c-4315-a876-b11fbfdfeed4")
Assert-AreEqual $expected.Name $P2SVpnGateway.Name
}
finally
{
# Delete P2SVpnGateway using Remove-AzP2sVpnGateway
$delete = Remove-AzP2sVpnGateway -Name $P2SVpnGatewayName -ResourceGroupName $rgName -Force -PassThru
Assert-AreEqual $True $delete

# Delete VpnServerConfiguration1 using Remove-AzVpnServerConfiguration
$delete = Remove-AzVpnServerConfiguration -ResourceGroupName $rgName -Name $VpnServerConfiguration1Name -Force -PassThru
Assert-AreEqual $True $delete

# Delete Virtual hub
$delete = Remove-AzVirtualHub -ResourceGroupName $rgname -Name $virtualHubName -Force -PassThru
Assert-AreEqual $True $delete

# Delete Virtual wan
$delete = Remove-AzVirtualWan -InputObject $virtualWan -Force -PassThru
Assert-AreEqual $True $delete

Clean-ResourceGroup $rgname
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@ public ExpressRoutePortTests(Xunit.Abstractions.ITestOutputHelper output)
{
}

[Fact(Skip = "Resource under whitelisting")]
[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
[Trait(Category.Owner, NrpTeamAlias.pgtm)]
public void TestExpressRoutePortCRUDMinimalParameters()
{
TestRunner.RunTestScript(string.Format("Test-ExpressRoutePortCRUD"));
}

[Fact(Skip = "Resource under whitelisting")]
[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
[Trait(Category.Owner, NrpTeamAlias.pgtm)]
public void TestExpressRoutePortIdentityCRUD()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public void TestGetTopology()
TestRunner.RunTestScript("Test-GetTopology");
}

[Fact]
[Fact(Skip = "Skipped due to backend issues")]
[Trait(Category.AcceptanceType, Category.CheckIn)]
[Trait(Category.Owner, NrpTeamAlias.netanalyticsdev)]
public void TestGetSecurityGroupView()
Expand Down Expand Up @@ -121,5 +121,13 @@ public void TestNetworkConfigurationDiagnostic()
{
TestRunner.RunTestScript("Test-NetworkConfigurationDiagnostic");
}

[Fact]
[Trait(Category.RunType, Category.LiveOnly)]
[Trait(Category.Owner, NrpTeamAlias.netanalyticsdev)]
public void TestCRUDFlowLog()
{
TestRunner.RunTestScript("Test-CRUDFlowLog");
}
}
}
Loading