Skip to content

Update Set-AzApiManagementGroup.md because of missing required parameter in example #11392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2020

Conversation

erwinkramer
Copy link
Contributor

@erwinkramer erwinkramer commented Mar 21, 2020

GroupId is a required parameter, please add this in the example as well.

Description

Checklist

  • [x ] I have read the Submitting Changes section of CONTRIBUTING.md
  • [x ] The title of the PR is clear and informative
  • [your job ] The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • [x ] The PR does not introduce breaking changes
  • [x ] If applicable, the changes made in the PR have proper test coverage
  • [x ] For public API changes to cmdlets:
    • [x ] a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • [x ] the markdown help files have been regenerated using the commands listed here

GroupId is a required parameter, please add this in the example as well.
@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@erwinkramer erwinkramer changed the title Update Set-AzApiManagementGroup.md Update Set-AzApiManagementGroup.md because of missing required parameter in example Mar 21, 2020
@msJinLei
Copy link
Contributor

@erwinkramer Please also add your modification explanation into the Changlog.md under ApiManagement folder, thanks.

@msftclas
Copy link

msftclas commented Mar 23, 2020

CLA assistant check
All CLA requirements met.

@erwinkramer
Copy link
Contributor Author

@msJinLei i've updated the changelog accordingly.

Move changelog from version 1.4 to upcoming release.
@msJinLei
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei
Copy link
Contributor

@msJinLei i've updated the changelog accordingly.

@erwinkramer, the changelog should be added under upcoming release. Please refer to my commit in your branch. You can follow that rule next time.

@msJinLei msJinLei merged commit a3af51a into Azure:master Mar 26, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
Update Set-AzApiManagementGroup.md because of missing required parameter in example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants