NEW PR Powershell cmdlets for list/get/cancel managed server operation #11452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
| * Add readable secondary parameter to Invoke-AzureSqlDatabaseFailover | ||
| * Add cmdlet Disable-AzSqlServerActiveDirectoryOnlyAuthentication | ||
| * Save sensitivity rank when classifying columns in the database. | ||
| * Add cmdlets Get-AzSqlInstanceOperation and Stop-AzSqlInstanceOperation |
There was a problem hiding this comment.
Please manually merge changelog, because above 3 items are in 2.5.0, don't change them. The last item should be put under upcoming release.
|
Can we please merge this since after waiting 20 days on the old PR: #11309 I encountered major issue while syncing code and I needed to create a new PR. |
8 tasks
|
@msJinLei , please review this PR with high priority. |
msJinLei
added
Cmdlet Review Required ⚠️
needs-revision
and removed
needs-review
labels
|
Cmdlet was reviewed here: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/510 |
msJinLei
approved these changes
Apr 1, 2020
src/Sql/Sql/ChangeLog.md
Outdated
| * Added readable secondary parameter to `Invoke-AzSqlDatabaseFailover` | ||
| * Added cmdlet `Disable-AzSqlServerActiveDirectoryOnlyAuthentication` | ||
| * Saved sensitivity rank when classifying columns in the database. | ||
| * Add readable secondary parameter to Invoke-AzureSqlDatabaseFailover |
There was a problem hiding this comment.
revert the change of version 2.5.0's log
| [ResourceNameCompleter("Microsoft.Sql/managedInstance/operations", "OperationName")] | ||
| [ValidateNotNullOrEmpty] | ||
| [SupportsWildcards] | ||
| public System.Guid Name { get; set; } |
There was a problem hiding this comment.
Name should be string here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New PR, since branch on the old one was messed up #11309.
PowerShell commands for list/get/cancel of managed server management operation.
Also added -AsJob parameter in Set-AzSqlInstance command to be able to test cancel in test. This operation should support execution in the back since it can lock powershell for a couple of hours.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added