-
Notifications
You must be signed in to change notification settings - Fork 4k
Storage 1.13.4-preview #11487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage 1.13.4-preview #11487
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 2 json files should not be merged on preview branch.
Can they be merged? Is there any risk? I hope to minimize manual work. |
They can't be merged since:
How about revise the automatic process by : when the build version has preview tag, skip update the 2 files. |
Got it. What I am thinking is on preview branch you can ignore those 2 files in code review. If so, 1 and 2 both won't be impact if you don't care about them. I'm learning the practice. Let's discuss again when PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not merge the 2 Json file, Dingmeng and I have a discussion, and finally both agreed not merge them.
Description
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added