AzureApiManagement breaking changes for api version 2019-12-01

[vfedonkin]

Description

Azure Api Management breaking changes for may build
Implementation of the changes described here: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/545
Breaking change notification was included into april rc:
#11602

Checklist

• [*] I have read the Submitting Changes section of CONTRIBUTING.md
• [* ] The title of the PR is clear and informative
• [* ] The appropriate ChangeLog.md file(s) has been updated:
  • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
  • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
• The PR does not introduce breaking changes
• [* ] If applicable, the changes made in the PR have proper test coverage
• [* ] For public API changes to cmdlets:
  • [* ] a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  • [* ] the markdown help files have been regenerated using the commands listed here

[adxsdkps]

Can one of the admins verify this patch?

[wyunchi-ms]

Please rerecord the test cases. @vfedonkin

[vfedonkin]

@wyunchi-ms , tests rerecorded.

[vfedonkin]

I will retarget this PR to "generation" branch, as told in https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/545

[vfedonkin]

@msJinLei , please advise, should we merge this PR into "generation" branch, or should we continue with the master? Generation branch doesn't have our ApiManagement code at all.

[vfedonkin]

@wyunchi-ms , tests rerecorded. Anything else required in this PR?
We must complete this before may build to include breaking changes in it

[solankisamir]

public class PsApiManagementSubscriptionKey //: PsApiManagementArmResource

remove this. #Resolved

---

Refers to: src/ApiManagement/ApiManagement.ServiceManagement/Models/PsApiManagementSubscriptionKey.cs:20 in 6015a7d. [](commit_id = 6015a7d, deletion_comment = False)

[solankisamir]

[solankisamir]

[wyunchi-ms]

Hi @vfedonkin , @solankisamir there are still 33 case failed in ApiManagement. Could you please rerecord these test cases?

[vfedonkin]

@wyunchi-ms , found it. Tests rerecorded.
I see some complains about help files: "Online version in the header of the file is incorrect"
But these help files are new and not published yet. Should I add online version anyway?

[solankisamir]

online version:

add online version here like

https://docs.microsoft.com/en-us/powershell/module/az.apimanagement/get-azapimanagementauthorizationserver

In this and other files

Get-AzApiManagementAuthorizationServerClientSecret.md Online version in the header of the file is incorrect. The cor.
Get-AzApiManagementIdentityProviderClientSecret.md Online version in the header of the file is incorrect. The cor.
Get-AzApiManagementNamedValue.md Online version in the header of the file is incorrect. The cor.
Get-AzApiManagementNamedValueSecretValue.md Online version in the header of the file is incorrect. The cor.
Get-AzApiManagementOpenIdConnectProviderClientSecret.md Online version in the header of the file is incorrect. The cor.
Get-AzApiManagementSubscriptionKey.md Online version in the header of the file is incorrect. The cor.
Get-AzApiManagementTenantAccessSecret.md Online version in the header of the file is incorrect. The cor.
Get-AzApiManagementTenantGitAccessSecret.md Online version in the header of the file is incorrect. The cor.
New-AzApiManagementNamedValue.md Online version in the header of the file is incorrect. The cor.
Remove-AzApiManagementNamedValue.md Online version in the header of the file is incorrect. The cor.
Set-AzApiManagementNamedValue.md

---

Refers to: src/ApiManagement/ApiManagement/help/Get-AzApiManagementAuthorizationServerClientSecret.md:4 in 0c4a985. [](commit_id = 0c4a985, deletion_comment = False)

[vfedonkin]

@wyunchi-ms , @solankisamir , tests rerecorded, help fixed

[vfedonkin]

@solankisamir , @wyunchi-ms , all checks are green now.

[solankisamir]