Skip to content

Remove -TenantLevel parameter used for on the Get-AzResourceLock cmdlet #11689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 7, 2020

Conversation

brucelin-511
Copy link
Contributor

Description

Remove -TenantLevel parameter used for on the Get-AzResourceLock cmdlet to fix the issue of
What is the -TenantLevel parameter used for on the Get-AzResourceLock cmdlet? #11335

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@isra-fel
Copy link
Member

isra-fel commented May 6, 2020

Hi @brucelin-511 , what would happen if the user used -TenantLevel before? The cmdlet returned nothing, or threw an error?

I ask because we cannot check in breaking changes without notifying our customers in advance, unless the function is already broken.

@brucelin-511
Copy link
Contributor Author

brucelin-511 commented May 7, 2020

@isra-fel Previously, adding -TenantLevel, it don't throw the error. Actually, the effect of adding it or not, the result is the same. Resource (management) locks are only valid at the Subscription, Resource Group, Resource scopes. TenantLevel should not be a parameter for the command.

isra-fel
isra-fel previously approved these changes May 7, 2020
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit f111bf0 into Azure:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants