Skip to content

[Storage] Preview release #11690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

wyunchi-ms
Copy link
Contributor

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@blueww
Copy link
Member

blueww commented Apr 24, 2020

The 2 json file should be removed from the PR, since:

  1. They will take a lot of trouble in merge master change to storage preview branch.
  2. The 2 files are used to track breaking change, and we don't need track breaking change for preview module.

@wyunchi-ms wyunchi-ms force-pushed the Az.Storage-2020-04-24-preview branch from 049f7ef to ad1d806 Compare April 26, 2020 01:59
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wyunchi-ms wyunchi-ms merged commit 0da6717 into Azure:Az.Storage-preview-v2 Apr 26, 2020
blueww pushed a commit to wastoresh/azure-powershell that referenced this pull request May 3, 2020
blueww pushed a commit to wastoresh/azure-powershell that referenced this pull request May 6, 2020
@wyunchi-ms wyunchi-ms deleted the Az.Storage-2020-04-24-preview branch May 29, 2020 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants