-
Notifications
You must be signed in to change notification settings - Fork 4k
Update Batch API version #1180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Batch API version #1180
Conversation
Some small changes to improve test robustness.
Hi @jasper-schneider, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
@@ -46,6 +46,9 @@ function Test-CreatesNewBatchAccount | |||
Assert-AreEqual $expected.Location $actual.Location | |||
Assert-AreEqual $expected.Tags[0]["Name"] $actual.Tags[0]["Name"] | |||
Assert-AreEqual $expected.Tags[0]["Value"] $actual.Tags[0]["Value"] | |||
Assert-True { $actual.CoreQuota -gt 0 } | |||
Assert-True { $actual.PoolQuota -gt 0 } | |||
Assert-True { $actual.ActiveJobAndJobScheduleQuota -gt 0 } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please align entire file. Replace tab with 4 spaces.
Looks like the Site Recovery tests failed in the on demand build. I didn't touch that code, so I just hit the Retry button and will hope for the best - let me know if you'd like me to take any action. |
@jasper-schneider you will most likely need to pull the latest changes from the dev branch at any rate |
Ok, just did a merge of upstream/dev |
@jasper-schneider That should do it. New on-demand run will he here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-on-demand/268/ |
Pulled in the updated NuGet packages with the new API versions
Added a new cmdlet for the new REST API with tests + help
Re-recorded the scenario tests to use the new APIs (why the PR appears so big)