Remove -all parameter from Get-AzureRMSubscription and Set-AzureRMContext #1194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| CreateTenant(tenantId))); | ||
| TryGetSubscriptionById(tenantId, subscriptionId, out subscription); | ||
| } | ||
| else |
There was a problem hiding this comment.
Since this is a public method, shouldn't we have a check here for subscriptionName not being null or whitespace? And throw an ArgumentException if not?
|
Reviewed, a couple of nits, otherwise this looks great |
…is specified in Get-AzureRmSubscription and Set-AzureRmContext cmdlets
|
addressed all review feedback. Waiting for CI passing and the on-demand job passing |
|
@yugangw-msft Looks like you need to pull the latest |
markcowl
added a commit
that referenced
this pull request
Oct 29, 2015
Remove -all parameter from Get-AzureRMSubscription and Set-AzureRMContext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hovsepm @amarzavery
Please get review started.
I made consolidation on the logics of "get-by-name" and "get-by-id", after confirmed with multiple people that there are duplicates