Skip to content

New Powershell commands for Subscription RP #12077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 1, 2020
Merged

New Powershell commands for Subscription RP #12077

merged 11 commits into from
Jul 1, 2020

Conversation

navysingla
Copy link
Contributor

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

adxsdkps commented Jun 6, 2020

Can one of the admins verify this patch?

@navysingla navysingla changed the title New Powershell commands New Powershell commands for Subscription RP Jun 6, 2020
@VeryEarly VeryEarly self-assigned this Jun 8, 2020
VeryEarly
VeryEarly requested changes Jun 8, 2020
View reviewed changes
Copy link
Collaborator

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please record new added test case

@navysingla
Copy link
Contributor Author

please record new added test case

Added record session

VeryEarly
VeryEarly requested changes Jun 22, 2020
View reviewed changes
Copy link
Collaborator

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve comments and re-record test case Test-NewSubscription

@navysingla
Copy link
Contributor Author

please resolve comments and re-record test case Test-NewSubscription

Re-recorded test case

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

VeryEarly
VeryEarly reviewed Jun 24, 2020
View reviewed changes
@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit fa0234e into Azure:master Jul 1, 2020
litchiyangMSFT pushed a commit to litchiyangMSFT/azure-powershell that referenced this pull request Aug 4, 2020
@navysingla @VeryEarly @litchiyangMSFT
New Powershell commands for Subscription RP (Azure#12077)
0701e00 
* New Powershell commands

* Update subscription

* Adding new offer types

* Adding session records

* Fixes

* Removing redundant parameters

* Add md file

* Update md files

* Update md file and new record test case

* Add online version

* Update ChangeLog.md

Co-authored-by: Yabo Hu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeryEarly VeryEarly VeryEarly approved these changes

Assignees

@VeryEarly VeryEarly

@navysingla navysingla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@navysingla @adxsdkps @VeryEarly @azuresdkci